fix(ion-slides) Swipe ion-slides is broken when multiples ion-slides are used #12213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrmlt
changed the title
|
Thank you for the pull request! |
|
Has this been released? |
|
No. If you want to use it right now you need to use the nightly RC build. See the linked issue for details. The actual release is still waiting on some other stuff to be cleaned up. |
|
Ok cool, np. I've got a temporary fix in the meantime |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
For desktop only, using swipe on ion-slides is broken when multiples ion-slides are present (#12008)
Changes proposed in this pull request:
Change the swiper listener target to
touchEventsTargetinstead ofplt.doc()Ionic Version: 2.x / 3.x
Fixes: #