fix(nav): Explicitly type the promise returned #12235
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Explicitly types the promise returned by
goToRootmethod. Since the type ofPromise.reject()is deduced to be of typePromise<never>by TypeScript it fails to compile as the classes extending the class (NavandTabs) are typed asPromise<any>.This problem only happens in TS 2.4 as there were improvements on inference for generics.
Changes proposed in this pull request:
goToRootmethod asPromise<any>instead of automatically deducedPromise<never>.Ionic Version: 3.x
Fixes: #12233