Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(navigation): done transition callback #12640

Merged
merged 3 commits into from
Aug 31, 2017
Merged

fix(navigation): done transition callback #12640

merged 3 commits into from
Aug 31, 2017

Conversation

soumak77
Copy link
Contributor

fixes #12499

@soumak77 soumak77 changed the title Fix nav done transition fix(navigation): done transition callback Aug 11, 2017
@soumak77
Copy link
Contributor Author

@danbucholtz can you review this PR and merge it for the next release?

@kensodemann kensodemann merged commit 0a6bb3b into ionic-team:master Aug 31, 2017
@kensodemann kensodemann mentioned this pull request Aug 31, 2017
Closed
@danbucholtz
Copy link
Contributor

@soumak77,

Thanks for the PR.

Thanks,
Dan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Browser back button with @IonicPage pages throws TypeError: e.done is not a function
3 participants
@soumak77 @danbucholtz @kensodemann