-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(alert-component): RTL fix for alert item's icon #12876
Conversation
This is a suggestion for RTL fix for icons on alert items (checkboxes and radios)
Did you try perhaps not duplicating the element, but using |
@AmitMY No I did not, I don't know if order can make the icon position correct though... |
How will using icons fix it? |
instead of dupplicate icons with *ngIf to check if it's rtl or not, an order will be used to place them correctly
@AmitMY You were right a simple order can make it right instead of duplicate icons however I still am not sure if we're using the same pattern as we used before, can you please check it? thanks. |
Yeah, this is the style for orders (custom properties in general). Thanks for the update @brandyscarney Can you please take a look at this minor fix? |
Sry my bad, this doesn't fix anything but also makes it even worse! |
Thank you for reviewing this @AmitMY! Just to be clear - this PR is no longer necessary? |
Short description of what this resolves:
This is a suggestion for RTL fix for icons on alert items (checkboxes
and radios)
Changes proposed in this pull request:
Ionic Version: 3.x
Fixes: #11211