Helps anyone looking for help know what to import from where. #12910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Someone seeking help obviously does not know where to import the loading controller from and would have to go on another round of google search to find where.
|
Thank you for the PR! This also makes this documentation more consistent with the other controller documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone seeking help obviously does not know where to import the loading controller from and would have to go on another round of google search to find where.
Short description of what this resolves:
Helps anyone looking for help know what to import from where.
Changes proposed in this pull request:
Imported LoadingController from ionic-angular
Ionic Version: 2.x / 3.x
Fixes: # Improved documentation.