New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(toast): only use constant and env if supported #14399

Merged

brandyscarney merged 1 commit into master from toast-iphone-support

Apr 27, 2018

Member

brandyscarney commented Apr 27, 2018 •

edited

Loading

Short description of what this resolves:

Check if constant/env are supported before using it in calc for the toast animation

Ionic Version: 4.x

To reproduce the issue, open the following url in Chrome on the master branch: http://localhost:3333/src/components/toast/test/basic

Try to open one of the top or bottom toasts in ios mode and you will see nothing happens.


          fix(toast): only use constant and env if supported

ce74e9b

brandyscarney requested a review from mhartington

April 27, 2018 15:49

mhartington approved these changes

View reviewed changes

brandyscarney merged commit 9bee0f0 into master

brandyscarney deleted the toast-iphone-support branch

April 27, 2018 15:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet