fix(button): add custom properties and remove --ion-color vars #15463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manucorporat
reviewed
Sep 4, 2018
| @@ -134,6 +212,7 @@ | |||
| outline: none; | |||
|
|
|||
| background: var(--background); | |||
| color: var(--color); | |||
There was a problem hiding this comment.
could we set the color in the host, and let text-inherit() do the rest?
There was a problem hiding this comment.
We could, but all of the places targeting background and color directly are on the button-native, examples:
| // iOS Toolbar Clear Button | ||
| // -------------------------------------------------- | ||
|
|
||
| ::slotted(*) .button.button-clear .button-native { |
There was a problem hiding this comment.
not sure this will work, .button-native is inside the shadow-dom
There was a problem hiding this comment.
honestly I think this is safe to remove. I don't even see a difference manually applying the height and there are no differences in the snapshot comparison without it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
references #14808 references #14853 references #14850
📷 📷 📷
Snapshot of this branch: https://ionic-snapshot-go.appspot.com/ionic-core/snapshots/yjw/chrome_400x800
📷 📷 📷
Comparison to master: https://ionic-snapshot-go.appspot.com/ionic-core/snapshots/e1x/yjw/chrome_400x800
Note that I renamed/split the
filltest tooutlineandclearsince theclearbuttons weren't visually in the window.