Skip to content

fix(core): matchBreakpoint will return true if breakPoint is empty string #15498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manucorporat merged 1 commit into from
Sep 7, 2018
Merged

fix(core): matchBreakpoint will return true if breakPoint is empty string #15498

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/utils/media.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export const SIZE_TO_MEDIA: any = {
// at the breakpoint passed
// e.g. matchBreakpoint('sm') => true if screen width exceeds 576px
export function matchBreakpoint(win: Window, breakpoint: string | undefined) {
if (breakpoint === undefined) {
if (breakpoint === undefined || breakpoint === '') {
return true;
}
const mediaQuery = SIZE_TO_MEDIA[breakpoint];
Expand Down