Skip to content

Add keep-alive functionality #18561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Add keep-alive functionality #18561

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2190aae
Add keep-alive functionality
michaeltintiuc Jun 17, 2019
4f5a84d
Merge branch 'master' into router-keep-alive
michaeltintiuc Jun 26, 2019
a40c75f
Merge branch 'master' of github.com:ionic-team/ionic into router-keep…
michaeltintiuc Jul 11, 2019
f350340
Merge branch 'router-keep-alive' of github.com:ModusCreateOrg/ionic i…
michaeltintiuc Jul 11, 2019
8538ab7
Merge branch 'master' into router-keep-alive
michaeltintiuc Jul 12, 2019
1b4dd26
Merge branch 'master' into router-keep-alive
michaeltintiuc Jul 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions vue/src/components/navigation/ion-vue-router.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,19 @@
import Vue, { CreateElement, RenderContext, VNodeData } from 'vue';
import Vue, { CreateElement, RenderContext, VNode, VNodeData } from 'vue';
import { NavDirection } from '@ionic/core';

type TransitionDone = () => void;

interface Props {
name: string;
animated: boolean;
}

interface KeepAliveProps {
include?: string | string[] | RegExp;
exclude?: string | string[] | RegExp;
max?: number;
}

// Component entering the view
let enteringEl: HTMLElement;

Expand All @@ -19,6 +26,8 @@ export default {
name: { default: 'default', type: String },
// Disable transitions
animated: { default: true, type: Boolean },
// keep-alive props
keepAlive: { type: [String, Object as () => KeepAliveProps] },
},

render(h: CreateElement, { parent, props, data, children }: RenderContext) {
Expand Down Expand Up @@ -47,12 +56,11 @@ export default {
leaveCancelled,
}
};
const routerViewNode: VNode = h('router-view', routerViewData, children);
const keepAliveNode: VNode = h('keep-alive', { props: { ...props.keepAlive } }, [routerViewNode]);
const transitionNode: VNode = h('transition', transitionData, [props.keepAlive === undefined ? routerViewNode : keepAliveNode]);

return h('ion-router-outlet', ionRouterOutletData, [
h('transition', transitionData, [
h('router-view', routerViewData, children)
])
]);
return h('ion-router-outlet', ionRouterOutletData, [transitionNode]);
}
};

Expand Down