WIP: New transition styles #2069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlynch
added a commit
that referenced
this pull request
Aug 24, 2014
feat(transitions): Improved iOS and Android transitions
Contributor
Author
|
Tested on iPhone, iPad and Android in the office. Looks good to me so I'm merging. |
|
💯 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to revisit our transitions and clean them up a bit. When we went to the box-shadow style iOS 7 transitions, we hit some performance issues. I tried a different approach that I think is better and lighter weight, and gets a similar effect.
Also, I've gone through and cleaned up references to
ios7and normalized them to justios. I did it in a simple way such that all the previous code should still work and it's backwards compatible.Also, I added a new transition called
slide-fullthat does a full slide rather than the offset slide on iOS, that I think is a better fit for Android.Also,
<ion-nav-views>has a black background and is positioned absolute with 100% width and height now by default which makes it possible to do a lightweight fade on transition. But I'm not yet sure of the full implications of this.TODO: