Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fab-button) : Undo the contain:strict #21905

Closed
wants to merge 1 commit into from

Conversation

Gwe-n
Copy link
Contributor

@Gwe-n Gwe-n commented Aug 10, 2020

Fixes #21772

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #21772

What is the new behavior?

The problem comes from the contain:strict which prevents .button-native from fitting with ion-fab-button. I only cancelled it in the .fab-button-small context.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Aug 10, 2020
@liamdebeasi liamdebeasi removed their request for review March 18, 2022 13:27
@liamdebeasi
Copy link
Contributor

Thanks for the PR and apologies for the delay. We appreciate the work you put into creating this.

After discussing with the team, we have decided not to move forward with this PR. Being able to click outside of the fab button to expand/collapse the fab list seems like a bug. We think that it would be better to move the click listener from ion-fab to ion-fab-button to avoid this problem entirely. ion-fab-button would then call a method on ion-fab to expand/collapse the fab list.

I am going to close this PR, however we do have plans to address this issue in a separate PR. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: small ion-fab-button with a ion-fab-list has a wrong click event area
2 participants