Skip to content

Conversation

@brandyscarney
Copy link
Member

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Adjusting the padding top or bottom on the toolbar was not inheriting this padding in the title for iOS only

Issue Number: fixes #23072

What is the new behavior?

It now inherits the top and bottom padding, this is not needed for MD since it doesn't use absolute positioning

Does this introduce a breaking change?

  • Yes
  • No

Other information

View test at http://localhost:3333/src/components/modal/test/custom

master branch
master branch

@brandyscarney brandyscarney requested a review from liamdebeasi May 21, 2021 16:06
@github-actions github-actions bot added the package: core @ionic/core package label May 21, 2021
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We should probably add a screenshot test so this does not regress.

There already is a screenshot test :)

@liamdebeasi liamdebeasi merged commit 82cfa55 into master Jun 3, 2021
@liamdebeasi liamdebeasi deleted the fix-inherit-padding-toolbar-title branch June 3, 2021 15:29
sakibguy added a commit to sakibguy/ionic-framework that referenced this pull request Jun 3, 2021
fix(title): inherit padding for iOS title in a toolbar (ionic-team#23343)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Ion toolbar does not center align middle content with start and end slot content

3 participants