Skip to content

Conversation

@liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented May 21, 2021

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #23323

Vue 3 switched to using a flat VNode structure which means they can no longer distinguish between props meant to be set as props vs those meant to be set as attributes. As a result, we need to explicitly reflect the color prop as an attribute, otherwise devs cannot query based on color (I.e. ion-button[color]) in Vue 3.

What is the new behavior?

  • Color prop is now reflected as an attribute in the DOM

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label May 21, 2021
@liamdebeasi liamdebeasi changed the title fix(core): reflect color property as an attribute for vue fix(all): reflect color property as an attribute for vue May 21, 2021
@liamdebeasi liamdebeasi merged commit dc430af into master May 21, 2021
@liamdebeasi liamdebeasi deleted the color-reflect branch May 21, 2021 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: @ionic/vue Leave visible attributes on ion elements when initialized inside of ion-router-outlet

2 participants