Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datetime): default sizing preserves shape of datetime #24104

Merged
merged 4 commits into from
Oct 21, 2021

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Oct 21, 2021

Also see ionic-team/ionic-docs#2087

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The default sizing of datetime did not look great when placed directly into a page. I also ran into some issues with that when using the datetime in the docs demos I am working on. These updates make the sizing a bit nicer.

next branch
image image

What is the new behavior?

  • Fixed datetime now keeps aspect ratio
  • Fixed datetime no longer sets a fixed width, but rather a max width so that the datetime still scales on smaller screens.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Contributor

@averyjohnston averyjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a typo, but otherwise this is good to go 👍

core/src/components/datetime/test/display/e2e.ts Outdated Show resolved Hide resolved
Co-authored-by: Amanda Smith <90629384+amandaesmith3@users.noreply.github.com>
@liamdebeasi liamdebeasi merged commit 71fab0f into next Oct 21, 2021
@liamdebeasi liamdebeasi deleted the datetime-sizing branch October 21, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants