Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(item): allow click targets inside of label #24225

Merged
merged 2 commits into from
Nov 17, 2021
Merged

fix(item): allow click targets inside of label #24225

merged 2 commits into from
Nov 17, 2021

Conversation

sean-perkins
Copy link
Contributor

@sean-perkins sean-perkins commented Nov 16, 2021

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Click targets inside of an ion-label are ignored.

Issue Number: #24215

What is the new behavior?

Pointer events are no longer disabled on the ion-label when slotted in an ion-item. This allows clicking the label to open a select as well as clicking a slotted button inside of an ion-label.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Maintains clickable labels used with select:

FW-332-resolution.mp4

@sean-perkins sean-perkins added the v6 issues specific to Framework v6 label Nov 16, 2021
@github-actions github-actions bot added the package: core @ionic/core package label Nov 16, 2021
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but the commit subject does not look correct. It should be fix(item) not fix(input)

Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge w/ updated commit subject

@sean-perkins sean-perkins changed the title fix(input): allow click targets inside of label fix(item): allow click targets inside of label Nov 17, 2021
@sean-perkins sean-perkins merged commit 3949a94 into next Nov 17, 2021
@sean-perkins sean-perkins deleted the FW-332 branch November 17, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package v6 issues specific to Framework v6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants