Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(overlays): define children custom elements #24372

Merged
merged 1 commit into from
Dec 10, 2021
Merged

fix(overlays): define children custom elements #24372

merged 1 commit into from
Dec 10, 2021

Conversation

sean-perkins
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The child custom element ion-picker-column is never defined by ion-picker.

Issue Number: #24366

What is the new behavior?

ion-picker will define ion-picker-column when the controller is constructed.

Updated our internal API for createController and createOverlay to support defining custom children elements.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Dec 10, 2021
@sean-perkins sean-perkins added the v6 issues specific to Framework v6 label Dec 10, 2021
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small readability issue, but otherwise looks good

core/src/utils/overlays.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@averyjohnston averyjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package v6 issues specific to Framework v6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants