Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular-server): publish only the dist directory to avoid import errors #24701

Merged
merged 2 commits into from
Feb 3, 2022

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Feb 2, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #24605

Similar to the Angular package, the Angular Server package expects only the dist directory to be published at the root, otherwise files will fail to load.

Additionally, with the Angular 12 build (3451a34) we now pass in tsconfig.json to ng-packagr. The tsconfig.json tells the compiler to build for Common JS, instead of ES2015 (what the @ionic/angular package currently does). This CJS instruction has been around for a while, but up until that commit we never passed tsconfig to ng-packagr

What is the new behavior?

  • Updated the package.json config to only publish dist as the root in @ionic/angular-server.
  • @ionic/angular-server is now build for es2015, just like @ionic/angular

Does this introduce a breaking change?

  • Yes
  • No

Other information

@liamdebeasi liamdebeasi requested a review from a team as a code owner February 2, 2022 21:05
@github-actions github-actions bot added the package: angular @ionic/angular package label Feb 2, 2022
@liamdebeasi liamdebeasi changed the title fix(angular-server): publish only the dist directory fix(angular-server): publish only the dist directory to avoid import errors Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Cannot find module '@ionic/angular-server' or its corresponding type declarations
3 participants