fix(angular-server): publish only the dist directory to avoid import errors #24701
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: resolves #24605
Similar to the Angular package, the Angular Server package expects only the dist directory to be published at the root, otherwise files will fail to load.
Additionally, with the Angular 12 build (3451a34) we now pass in tsconfig.json to
ng-packagr
. The tsconfig.json tells the compiler to build for Common JS, instead of ES2015 (what the @ionic/angular package currently does). This CJS instruction has been around for a while, but up until that commit we never passed tsconfig to ng-packagrWhat is the new behavior?
dist
as the root in @ionic/angular-server.Does this introduce a breaking change?
Other information