fix(input): clear button of ion-input remains gray #26217
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docsrepo, in a separate PR. See the contributing guide for details.npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
The clear button color remains gray
Issue URL:
#19178
What is the new behavior?
The clear button color match the color set by --ion-color-step-600
Does this introduce a breaking change?
Other information
In the bug report SidiBecker mention that it is not possible to change the color of the clear button icon. This is due to the fact that css variables can not be used inside an url("...") function in css. My fix use the mask-image property and allow the color to be set via background-color. For browsers who are not supporting mask-image the old behavior is used as a fallback.
I am new to this project. I had trouble to understand and run tests. I don't know if it's the way to go but I simply had a new element in
core/src/components/input/test/basic/index.htmlto showcase my changes.