Skip to content

feat(input): add disabled state #26227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 73 commits into from
Nov 8, 2022
Merged

feat(input): add disabled state #26227

merged 73 commits into from
Nov 8, 2022

Conversation

liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: N/A

Disabled state did not render correctly with new input syntax. The input was dimmed but not the label.

What is the new behavior?

  • The entire component is now dimmed when the component is disabled
  • Added disabled screenshot test
  • Added readonly screenshot test

Does this introduce a breaking change?

  • Yes
  • No

Other information

liamdebeasi and others added 30 commits October 31, 2022 15:38
@liamdebeasi
feat(input): add new js and css props
621dc13
@liamdebeasi
chore(): copy updates
d24428c
@liamdebeasi
test(input): move old tests to legacy directory
0402ae8
@liamdebeasi
feat(input): add legacy vs modern template rendering
7643d2d
@liamdebeasi
refactor(form): add form controller
259a3a2
@liamdebeasi
chore(): update comments
a989e94
@liamdebeasi
chore(): update tests
2a80a5f
@liamdebeasi
chore(): add moved screenshots
08ea3a0
@liamdebeasi
chore(): add moved screenshots
bd80054
@liamdebeasi
chore(): fix test file
19f4994
@liamdebeasi
chore(): prettier
d02c144
@liamdebeasi
feat(input): add base functionality and tests
cea5615
@liamdebeasi
feat(input): add missing fixed label
8d7f0c4
@liamdebeasi
feat(input): add basic help text rendering
6eabc11
@liamdebeasi
feat(input): add helper and error text
0259004
@liamdebeasi
chore(): update descriptions for clarity
5f765a0
@liamdebeasi
test(input): make sure correct content is rendered
3e4f70c
@liamdebeasi
test(input): make sure error color can be customized
232d868
@liamdebeasi
chore(): update test
2f6019b
@Ionitron
chore(): add updated snapshots
5c3bb0c
@liamdebeasi
refactor(item): deprecate helper and error slots
f8dc97f
@liamdebeasi
Merge branch '2591-helper' of https://github.com/ionic-team/ionic-fra…
23af9da 
…mework into 2591-helper
@liamdebeasi
feat(input): add counter support
eeb7124
@liamdebeasi
refactor(item): deprecate counter and counterFormatter
b9da66c
@liamdebeasi
chore(): a few tweaks
516a615
@liamdebeasi
test(input): clean up tests
2d07367
@liamdebeasi
Merge remote-tracking branch 'origin/2591-helper' into 2591-counter
4a4aca7
@liamdebeasi
test(input): add counter tests
f855134
@liamdebeasi
chore(): update prop description
a7e4426
@liamdebeasi
Merge remote-tracking branch 'origin/FW-2591' into 2591-props
fff8ed1
liamdebeasi and others added 17 commits November 2, 2022 18:01
@liamdebeasi
chore(): fix el type
4272366
@liamdebeasi
Merge remote-tracking branch 'origin/2591-props' into 2591-template
6d09ad6
@liamdebeasi
Merge remote-tracking branch 'origin/2591-template' into 2591-base
9632c22
@liamdebeasi
Merge remote-tracking branch 'origin/2591-base' into 2591-helper
79ff704
@liamdebeasi
Merge remote-tracking branch 'origin/2591-helper' into 2591-counter
aa7edae
@liamdebeasi
chore(): sync
15b1ab6
@liamdebeasi
chore(): padding is set on wrapper
7670a27
@liamdebeasi
chore(): use mixin
0a66283
@liamdebeasi
fix(input): padding applied to input wrapper
3408223
@liamdebeasi
fix(input): fixed label does not have end margin
10d2af3
@Ionitron
chore(): add updated snapshots
0dceaf6
@liamdebeasi
refactor(input): move label class to host
49c7563
@liamdebeasi
Revert "chore(): add updated snapshots"
a85ca3b 
This reverts commit 0dceaf6.
@liamdebeasi
fix(input): adjust size and label offset
e58033b
@Ionitron
chore(): add updated snapshots
04e17bb
@liamdebeasi
test(input): add disabled and readonly test
d12f1d4
@liamdebeasi
feat(input): add disabled and readonly support
3def77c
@github-actions github-actions bot added the package: core @ionic/core package label Nov 3, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review November 3, 2022 21:09
@liamdebeasi liamdebeasi requested a review from a team as a code owner November 3, 2022 21:09
Base automatically changed from 2591-placement to FW-2591 November 8, 2022 16:00
@liamdebeasi liamdebeasi merged commit e03b1fb into FW-2591 Nov 8, 2022
@liamdebeasi liamdebeasi deleted the 2591-disabled-readonly branch November 8, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sean-perkins sean-perkins sean-perkins approved these changes

@averyjohnston averyjohnston averyjohnston approved these changes

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liamdebeasi @sean-perkins @averyjohnston @Ionitron