Skip to content

fix(input): item and clear input styling is correct #26238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 173 commits into from
Nov 11, 2022
Merged

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Nov 7, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Using the modern input inside of an item caused incorrect padding to render. Also, the highlight line was partially obscured by the item's line.

Additionally, the clear input button was misaligned

What is the new behavior?

  • The clear input button is now aligned correctly at the end of the line
  • The end padding on ion-item is removed when using the modern input
  • The highlight is now visible in ion-item when using the modern input
  • Add TODOs for cleaning up legacy input

Note: I also added a few tests that looks at all of ion-input when using the bottom content. It's 3 tests so I added it while working on this fix. Let me know if you'd prefer that be in a separate PR though.

Does this introduce a breaking change?

  • Yes
  • No

Other information

liamdebeasi and others added 30 commits October 31, 2022 15:38
@liamdebeasi liamdebeasi changed the title 2591 tests fix(input): styling in item is correct Nov 7, 2022
@liamdebeasi liamdebeasi changed the title fix(input): styling in item is correct fix(input): item and clear input styling is correct Nov 7, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review November 7, 2022 22:25
@liamdebeasi liamdebeasi requested a review from a team as a code owner November 7, 2022 22:25
Base automatically changed from 2591-color to FW-2591 November 11, 2022 17:54
@liamdebeasi liamdebeasi merged commit 9a9568c into FW-2591 Nov 11, 2022
@liamdebeasi liamdebeasi deleted the 2591-tests branch November 11, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants