Skip to content

docs(config): update innerHTML comments #27032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 27, 2023
Merged

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Mar 27, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

When merging #27029 I forgot to update the comment in Ionic config to note that this now defaults to false.

What is the new behavior?

  • Updated comment to note the config defaults to false.
  • I also updated the comments for properties that rely on this config to clarify that plaintext behavior is the default.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the package: core @ionic/core package label Mar 27, 2023
@liamdebeasi liamdebeasi changed the title Update config.ts docs(config): update innerHTML defaults Mar 27, 2023
@liamdebeasi liamdebeasi changed the title docs(config): update innerHTML defaults docs(config): update innerHTML default comments Mar 27, 2023
@liamdebeasi liamdebeasi changed the title docs(config): update innerHTML default comments docs(config): update innerHTML comments Mar 27, 2023
@liamdebeasi liamdebeasi marked this pull request as ready for review March 27, 2023 17:40
@liamdebeasi liamdebeasi requested a review from a team as a code owner March 27, 2023 17:40
@liamdebeasi liamdebeasi merged commit 5c0ead3 into feature-7.0 Mar 27, 2023
@liamdebeasi liamdebeasi deleted the liamdebeasi-patch-1 branch March 27, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants