Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(tabs): document methods only available for vanilla #27269

Merged
merged 3 commits into from
Apr 26, 2023
Merged

Conversation

mapsandapps
Copy link
Contributor

@mapsandapps mapsandapps commented Apr 24, 2023

When using Angular, React, or Vue, the use of tabs is coupled to the framework's routing. These methods are only available when using tabs with vanilla JavaScript.

Issue number: N/A


What is the new behavior?

  • Adds more context to the description of the methods on tabs

Does this introduce a breaking change?

  • Yes
  • No

Other information

@stackblitz
Copy link

stackblitz bot commented Apr 24, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the package: core @ionic/core package label Apr 24, 2023
@mapsandapps mapsandapps marked this pull request as ready for review April 25, 2023 14:51
@mapsandapps mapsandapps requested a review from a team as a code owner April 25, 2023 14:51
@brandyscarney
Copy link
Member

Do we want to specifically mention Stencil here? I know we have been trying to discourage developers from using Stencil for mobile apps.

@mapsandapps
Copy link
Contributor Author

@brandyscarney Sure, that makes sense. I used that verbiage since that's what we're saying here. Should I make a PR to the docs repo to update that too?

@sean-perkins
Copy link
Contributor

Yeah I think we should simplify the language on the docs. Cut out Stencil, the documentation pertains to any JS environment that isn't one of our official framework wrapped packages.

@mapsandapps mapsandapps added this pull request to the merge queue Apr 26, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 26, 2023
@liamdebeasi liamdebeasi added this pull request to the merge queue Apr 26, 2023
Merged via the queue into main with commit db121ac Apr 26, 2023
@liamdebeasi liamdebeasi deleted the FW-1168 branch April 26, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants