chore: sync with main #27583
Merged
chore: sync with main #27583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue number: resolves #21764 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> The `prevSelected` returns the same value as `selectedIndex`. When a user has selected the first option then the second: - `prevSelected` returns `1` - `selectedIndex` returns `1` ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> The `prevSelected` returns the index of the last selected option. When a user has selected the first option then the second: - `prevSelected` returns `0` - `selectedIndex` returns `1` ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Read the comment below regarding `toHaveReceivedEventDetail`.
Issue number: resolves #25990 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> The tab bar and footer are being shown too soon after the keyboard begins to hide. This is happening because the webview resizes _after_ the keyboard begins to dismiss. As a result, it is possible for the tab bar and footer to briefly appear on the top of the keyboard in environments where the webview resizes. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - The tab bar and footer wait until after the webview has resized before showing again | before | after | | - | - | | <video src="https://user-images.githubusercontent.com/2721089/236905066-42ac17a5-a5bf-458b-9c62-005fcce05e20.MP4"></video> | <video src="https://user-images.githubusercontent.com/2721089/236905185-d2f539d1-6d93-4385-b1cb-24dd7aa06393.MP4"></video> | This code works by adding an optional parameter to the keyboard controller callback called `waitForResize`. When defined, code within Ionic can wait for the webview to resize as a result of the keyboard opening or closing. Tab bar and footer wait for this `waitForResize` promise to resolve before re-showing the relevant elements. This `waitForResize` parameter is only only defined when all of the following are two: **1. The webview resize mode is known and is _not_ "None".** If the webview resize mode is unknown then either the Keyboard plugin is not installed (in which case the tab bar/footer are never hidden in the first place) or the app is being deployed in a browser/PWA environment (in which case the web content typically does not resize). If the webview resize mode is "None" then that means the keyboard plugin is installed, but the webview is configured to never resize when the keyboard opens/closes. As a result, there is no need to wait for the webview to resize. **2. The webview has previously resized.** If the keyboard is closed _before_ the opening keyboard animation completes then it is possible for the webview to never resize. In this case, the webview is at full height and the tab bar/footer can immediately be re-shown. ------ Under the hood, we use a [ResizeObserver](https://developer.mozilla.org/en-US/docs/Web/API/ResizeObserver) to listen for when the web content resizes. Which element we listen on depends on the resize mode set in the developer's Capacitor app. We determine this in the `getResizeContainer` function. From there, we wait for the ResizeObserver callback, then wait 1 more frame so the promise resolves _after_ the resize has finished. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Dev build: `7.0.6-dev.11683905366.13943af0`
Release 7.0.7
…ct) to have consistent disabled opacity (#27396) Issue number: resolves #27184 --------- ## What is the current behavior? The modern form controls do not use the same opacity for their labels when disabled, resulting in inconsistent UI when using two different types in the same view (select vs checkbox, for example). ## What is the new behavior? The checkbox, input, radio, range, select, textarea and toggle labels have been updated on both modes to use the same opacity as each other when disabled. The checkbox and radio icons have been updated to use a different opacity than the label for `md` mode. - Updates `ios` mode so all form controls use the same opacity of `0.3` - I could not find any guidelines by Apple for what color these should be, so I decided to just make them the same as what is most commonly used & match item - Updates `md` mode so all form control labels use the same opacity of `0.38` - I used the [Material Design 3 documentation](https://m2.material.io/components) to get this number as well as the opacity of the disabled selection controls in the [Material Design 2 figma design kit](https://www.figma.com/community/file/778763161265841481). The Material Design 2 documentation does not mention the opacity, but this is also the number used by Material Design 1 so it's safe to assume it is what the disabled form labels should also use for Material Design 2. - Updates the `md` range so the slotted elements are also included when setting the opacity on the label - Updates the range, radio & checkbox tests to make sure there are screenshots in the different disabled states - Updates the item/disabled test to include radio & textarea so you can see all form controls side by side ## Does this introduce a breaking change? - [ ] Yes - [x] No ## Other information I downloaded screenshots of the item disabled tests and put them side by side for `main` and this branch in order to see the differences in the labels. The grey boxes to the left of each item are just a bigger version of the label color for that item, so it's easier to see when they aren't the same.   --------- Co-authored-by: ionitron <hi@ionicframework.com>
Issue number: Resolves #22176 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Translucent popovers do not get blurred in Chromium ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Translucent popover gets blurred in Chromium Note: existing screenshot tests nicely show the change in behavior. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information Because of the [existing, apparently intentional](https://bugs.chromium.org/p/chromium/issues/detail?id=1148826) behavior in Chromium browsers with `backdrop-filter` and animation, we need to either animate the arrow and content instead of the wrapper or apply the filter to a different element. Here, I've animated the arrow and content instead of the wrapper. The fix only needs to apply in `ios` mode. The translucent option is not supported in `md` mode. <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> --------- Co-authored-by: ionitron <hi@ionicframework.com>
…in /core (#27501) Bumps [@stencil/vue-output-target](https://github.com/ionic-team/stencil-ds-output-targets) from 0.8.4 to 0.8.5. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/ionic-team/stencil-ds-output-targets/commits">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Screenshots in a branch are currently compared against the screenshots on `main`. While we ultimately need to compare against ground truths in `main`, this can cause tests to seemingly fail at random. For example, this branch was created based on eb2772c. However, 381de0b was added to `main` after the first commit and has new screenshot diffs. I do not have the latest ground truths for the changed screenshots in this branch, so the screenshot tests failed in https://github.com/ionic-team/ionic-framework/actions/runs/4995702351/jobs/8947969061 even though I did not change any component implementations. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Test runs in CI now run against the ground truths available in the branch. When a commit is added to the merge queue, it will be tested against the latest `main` and any commits ahead of it in the queue. As a result, if there _is_ a conflict then the test run will fail at that point and the commit will be removed from the merge queue. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
…odals and popovers (#27491) Issue number: resolves #27205 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> If an Angular component that makes use of `ModalController` or `PopoverController` has a property of its own named `modal` or `popover` respectively, this will collide with an internal reference to the modal/popover element and cause errors. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> The actual behavior is unchanged, but a console error is logged guiding the developer on how to fix the issue. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> I used the original reproduction from the issue to test. Full steps: 1. Clone the repo: https://github.com/Asac2142/expenses 2. Run `git checkout ef95c2e80a9991fe958d628f17ecc4e862c834ef` to get to the app's state from when the issue was originally posted. Observe that the component in `src/app/home/create-transaction` has a private prop named `modal`. 3. Run `npm install`, then install the dev build: `npm install @ionic/angular@7.0.7-dev.11684263140.15c242cf` 4. Run `ionic serve`. Click the fab button in the lower right. Observe the console error. If you scroll down in the modal and click the Category button, this will trigger the originally-reported issue. 5. Rename the private `modal` variable to something else, like `_modal`. 6. Refresh the page and re-open the modal. Note that no error is logged, and the Category button can be clicked to open another modal without issue.
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> The `basic` test for `ion-select` contains a lot of content that is either duplicated within the test, duplicated by other tests, or simply not used/needed. Additionally, some select options (notably gender and hair color) are not inclusive. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> Test template cleaned up, and options replaced with less personal ones as needed. Legacy test HTML was intentionally left alone since we'll be removing that in the near future anyway, though I did have to tweak a legacy E2E test since it was visiting the non-legacy page. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
…re (#27351) Bumps [@axe-core/playwright](https://github.com/dequelabs/axe-core-npm) from 4.6.1 to 4.7.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/dequelabs/axe-core-npm/releases"><code>@axe-core/playwright</code>'s releases</a>.</em></p> <blockquote> <h2>Release 4.7.0</h2> <h3>Bug Fixes</h3> <ul> <li><strong>cli:</strong> do not inject script tags due to pages not allowing script tags (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/710">#710</a>) (<a href="https://github.com/dequelabs/axe-core-npm/commit/2e0fdb4a4661040b9b8dbb91bed1a96142e4fe0c">2e0fdb4</a>)</li> </ul> <h3>Features</h3> <ul> <li>enable esm import (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/713">#713</a>) (<a href="https://github.com/dequelabs/axe-core-npm/commit/076bfa99f27f416b4eaff6d24cc23e8573fc72ee">076bfa9</a>)</li> <li>support WDIO v8 (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/708">#708</a>) (<a href="https://github.com/dequelabs/axe-core-npm/commit/1e40ec006844a9b5f0e368b5ca8014e215c75372">1e40ec0</a>)</li> <li>Update axe-core to v4.7.0 (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/709">#709</a>) (<a href="https://github.com/dequelabs/axe-core-npm/commit/d418d093b4c462d5d60e0f7ad3d5147bcaf52aa2">d418d09</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/dequelabs/axe-core-npm/blob/develop/CHANGELOG.md"><code>@axe-core/playwright</code>'s changelog</a>.</em></p> <blockquote> <h1><a href="https://github.com/dequelabs/axe-core-npm/compare/v4.6.1...v4.7.0">4.7.0</a> (2023-04-28)</h1> <h3>Bug Fixes</h3> <ul> <li><strong>cli:</strong> do not inject script tags due to pages not allowing script tags (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/710">#710</a>) (<a href="https://github.com/dequelabs/axe-core-npm/commit/2e0fdb4a4661040b9b8dbb91bed1a96142e4fe0c">2e0fdb4</a>)</li> </ul> <h3>Features</h3> <ul> <li>enable esm import (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/713">#713</a>) (<a href="https://github.com/dequelabs/axe-core-npm/commit/076bfa99f27f416b4eaff6d24cc23e8573fc72ee">076bfa9</a>)</li> <li>support WDIO v8 (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/708">#708</a>) (<a href="https://github.com/dequelabs/axe-core-npm/commit/1e40ec006844a9b5f0e368b5ca8014e215c75372">1e40ec0</a>)</li> <li>Update axe-core to v4.7.0 (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/709">#709</a>) (<a href="https://github.com/dequelabs/axe-core-npm/commit/d418d093b4c462d5d60e0f7ad3d5147bcaf52aa2">d418d09</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/dequelabs/axe-core-npm/commit/076bfa99f27f416b4eaff6d24cc23e8573fc72ee"><code>076bfa9</code></a> feat: enable esm import (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/713">#713</a>)</li> <li><a href="https://github.com/dequelabs/axe-core-npm/commit/2e0fdb4a4661040b9b8dbb91bed1a96142e4fe0c"><code>2e0fdb4</code></a> fix(cli): do not inject script tags due to pages not allowing script tags (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/710">#710</a>)</li> <li><a href="https://github.com/dequelabs/axe-core-npm/commit/d418d093b4c462d5d60e0f7ad3d5147bcaf52aa2"><code>d418d09</code></a> feat: Update axe-core to v4.7.0 (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/709">#709</a>)</li> <li><a href="https://github.com/dequelabs/axe-core-npm/commit/1e40ec006844a9b5f0e368b5ca8014e215c75372"><code>1e40ec0</code></a> feat: support WDIO v8 (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/708">#708</a>)</li> <li><a href="https://github.com/dequelabs/axe-core-npm/commit/50989f3746fd8f50034e4a34b29af65a84cfb7f1"><code>50989f3</code></a> Merge pull request <a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/702">#702</a> from dequelabs/master</li> <li><a href="https://github.com/dequelabs/axe-core-npm/commit/53b529b2dc94569974fdecadb8cf2021c2985085"><code>53b529b</code></a> Merge pull request <a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/701">#701</a> from dequelabs/release-1680033362</li> <li><a href="https://github.com/dequelabs/axe-core-npm/commit/5493968c4a19127c1a716045c0dfdf24cc30ef46"><code>5493968</code></a> chore: release v4.6.1</li> <li>See full diff in <a href="https://github.com/dequelabs/axe-core-npm/compare/v4.6.1...v4.7.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
Issue number: resolves #21205 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> `picker-column` keeps using LTR display when using RTL. LTR: `Column 1 Column 2` RTL: `Column 1 Column 2` ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> `picker-column` correctly displays for RTL. LTR: `Column 1 Column 2` RTL: `Column 2 Column 1` ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> This PR is already being tested through the `picker -> basic` and `picker -> value` screenshots. Due to those tests, a new test is not needed to verify the fix. The current fix is only changing the `picker` and `picker-column`. The `datetime` and `datetime-button` do not change, leaving the format up to the users. It wouldn't change the functionality that was provided through PR #17018. --------- Co-authored-by: ionitron <hi@ionicframework.com>
Issue number: N/A [The Stencil team has moved their community from Slack to Discord](https://twitter.com/stenciljs/status/1658561079767887873). --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> There is a link to the Slack. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - There is a link to the Discord. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
…re (#27520) Bumps [@axe-core/playwright](https://github.com/dequelabs/axe-core-npm) from 4.7.0 to 4.7.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/dequelabs/axe-core-npm/releases"><code>@axe-core/playwright</code>'s releases</a>.</em></p> <blockquote> <h2>Release 4.7.1</h2> <h3>Bug Fixes</h3> <ul> <li>proper imports in esm context (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/718">#718</a>) (<a href="https://github.com/dequelabs/axe-core-npm/commit/f2a41bcaf33f5000fa1cd08f1a3e184b5d6360be">f2a41bc</a>)</li> <li><strong>react:</strong> include .mjs file in publish (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/722">#722</a>) (<a href="https://github.com/dequelabs/axe-core-npm/commit/a7bf92fd9856b7be0fea4f3c8bd38a79a3c9fde3">a7bf92f</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/dequelabs/axe-core-npm/blob/develop/CHANGELOG.md"><code>@axe-core/playwright</code>'s changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/dequelabs/axe-core-npm/compare/v4.7.0...v4.7.1">4.7.1</a> (2023-05-02)</h2> <h3>Bug Fixes</h3> <ul> <li>proper imports in esm context (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/718">#718</a>) (<a href="https://github.com/dequelabs/axe-core-npm/commit/f2a41bcaf33f5000fa1cd08f1a3e184b5d6360be">f2a41bc</a>)</li> <li><strong>react:</strong> include .mjs file in publish (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/722">#722</a>) (<a href="https://github.com/dequelabs/axe-core-npm/commit/a7bf92fd9856b7be0fea4f3c8bd38a79a3c9fde3">a7bf92f</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/dequelabs/axe-core-npm/commit/a7bf92fd9856b7be0fea4f3c8bd38a79a3c9fde3"><code>a7bf92f</code></a> fix(react): include .mjs file in publish (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/722">#722</a>)</li> <li><a href="https://github.com/dequelabs/axe-core-npm/commit/f2a41bcaf33f5000fa1cd08f1a3e184b5d6360be"><code>f2a41bc</code></a> fix: proper imports in esm context (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/718">#718</a>)</li> <li><a href="https://github.com/dequelabs/axe-core-npm/commit/aa12d43cc3670b9aa9b4db80f4bb5251a032c171"><code>aa12d43</code></a> Merge pull request <a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/716">#716</a> from dequelabs/master</li> <li><a href="https://github.com/dequelabs/axe-core-npm/commit/623da3a516cbf1c7a0a0461b23a8c98f094cc18d"><code>623da3a</code></a> Merge pull request <a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/715">#715</a> from dequelabs/release-1682703518</li> <li><a href="https://github.com/dequelabs/axe-core-npm/commit/e4ada1bf9985e9a7dfd2e0b4552bae1e1f5f3bbe"><code>e4ada1b</code></a> chore: release v4.7.0</li> <li>See full diff in <a href="https://github.com/dequelabs/axe-core-npm/compare/v4.7.0...v4.7.1">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Hey guys, I've found a minor issue. There is a duplicate selector for the same rules. The lines `:24` and `:25` are the same.
) Bumps [@stencil/sass](https://github.com/ionic-team/stencil-sass) from 3.0.2 to 3.0.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil-sass/releases"><code>@stencil/sass</code>'s releases</a>.</em></p> <blockquote> <h2>v3.0.3</h2> <h2>Dependency Updates</h2> <p><code>@ionic/prettier-config</code></p> <ul> <li>chore(deps-dev): bump <code>@ionic/prettier-config</code> from 2.1.2 to 3.0.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/295">ionic-team/stencil-sass#295</a></li> </ul> <p><code>@stencil/core</code></p> <ul> <li>chore(deps-dev): bump <code>@stencil/core</code> from 3.2.1 to 3.2.2 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/292">ionic-team/stencil-sass#292</a></li> </ul> <p><code>rimraf</code></p> <ul> <li>chore(deps-dev): bump rimraf from 5.0.0 to 5.0.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/315">ionic-team/stencil-sass#315</a></li> </ul> <p><code>rollup</code></p> <ul> <li>chore(deps-dev): bump rollup from 3.21.0 to 3.21.3 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/294">ionic-team/stencil-sass#294</a></li> <li>chore(deps-dev): bump rollup from 3.21.3 to 3.21.5 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/298">ionic-team/stencil-sass#298</a></li> <li>chore(deps-dev): bump rollup from 3.21.5 to 3.21.6 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/303">ionic-team/stencil-sass#303</a></li> <li>chore(deps-dev): bump rollup from 3.21.6 to 3.21.7 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/307">ionic-team/stencil-sass#307</a></li> <li>chore(deps-dev): bump rollup from 3.21.7 to 3.22.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/311">ionic-team/stencil-sass#311</a></li> <li>chore(deps-dev): bump rollup from 3.22.0 to 3.23.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/317">ionic-team/stencil-sass#317</a></li> </ul> <p><code>terser</code></p> <ul> <li>chore(deps-dev): bump terser from 5.17.1 to 5.17.2 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/299">ionic-team/stencil-sass#299</a></li> <li>chore(deps-dev): bump terser from 5.17.2 to 5.17.3 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/301">ionic-team/stencil-sass#301</a></li> <li>chore(deps-dev): bump terser from 5.17.3 to 5.17.4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/310">ionic-team/stencil-sass#310</a></li> <li>chore(deps-dev): bump terser from 5.17.4 to 5.17.5 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/318">ionic-team/stencil-sass#318</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/ionic-team/stencil-sass/compare/v3.0.2...v3.0.3">https://github.com/ionic-team/stencil-sass/compare/v3.0.2...v3.0.3</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ionic-team/stencil-sass/commit/20d69011f515ee3d5a727aa89c4a987d568ca3af"><code>20d6901</code></a> 3.0.3</li> <li><a href="https://github.com/ionic-team/stencil-sass/commit/b6c58c021891ac92964b56fb70c90818aadca0b4"><code>b6c58c0</code></a> chore(deps-dev): bump rollup from 3.22.0 to 3.23.0 (<a href="https://redirect.github.com/ionic-team/stencil-sass/issues/317">#317</a>)</li> <li><a href="https://github.com/ionic-team/stencil-sass/commit/fbf94710013d7009801229ec24b729e98eef6350"><code>fbf9471</code></a> chore(deps-dev): bump terser from 5.17.4 to 5.17.5 (<a href="https://redirect.github.com/ionic-team/stencil-sass/issues/318">#318</a>)</li> <li><a href="https://github.com/ionic-team/stencil-sass/commit/d0d6f94cb91f3cc2fa4ddd933a49741b4991e02a"><code>d0d6f94</code></a> chore(deps-dev): bump terser from 5.17.3 to 5.17.4 (<a href="https://redirect.github.com/ionic-team/stencil-sass/issues/310">#310</a>)</li> <li><a href="https://github.com/ionic-team/stencil-sass/commit/73735770d5d05622f3499c61654d9e8d6dfbe3e5"><code>7373577</code></a> chore(deps-dev): bump rollup from 3.21.7 to 3.22.0 (<a href="https://redirect.github.com/ionic-team/stencil-sass/issues/311">#311</a>)</li> <li><a href="https://github.com/ionic-team/stencil-sass/commit/741250eb83e1316f59e0261f161c415465fda5a8"><code>741250e</code></a> chore(deps-dev): bump rimraf from 5.0.0 to 5.0.1 (<a href="https://redirect.github.com/ionic-team/stencil-sass/issues/315">#315</a>)</li> <li><a href="https://github.com/ionic-team/stencil-sass/commit/0936ebd1e4d6d0f5530bf134c8fd9c1b01e8f4b9"><code>0936ebd</code></a> chore(deps-dev): bump rollup from 3.21.6 to 3.21.7 (<a href="https://redirect.github.com/ionic-team/stencil-sass/issues/307">#307</a>)</li> <li><a href="https://github.com/ionic-team/stencil-sass/commit/ddf9b95c658cc80c07a908f4159e22078f3ec685"><code>ddf9b95</code></a> chore(deps-dev): bump rollup from 3.21.5 to 3.21.6 (<a href="https://redirect.github.com/ionic-team/stencil-sass/issues/303">#303</a>)</li> <li><a href="https://github.com/ionic-team/stencil-sass/commit/49f2ad92d67623a6b812d33cc6ee4b761ac8ab58"><code>49f2ad9</code></a> chore(deps-dev): bump terser from 5.17.2 to 5.17.3 (<a href="https://redirect.github.com/ionic-team/stencil-sass/issues/301">#301</a>)</li> <li><a href="https://github.com/ionic-team/stencil-sass/commit/abd6406921ff7c5add3bbe562ca49ba3fe8f5db1"><code>abd6406</code></a> chore(deps-dev): bump terser from 5.17.1 to 5.17.2 (<a href="https://redirect.github.com/ionic-team/stencil-sass/issues/299">#299</a>)</li> <li>Additional commits viewable in <a href="https://github.com/ionic-team/stencil-sass/compare/v3.0.2...v3.0.3">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…7.0 in /core (#27537) Bumps [@stencil/angular-output-target](https://github.com/ionic-team/stencil-ds-output-targets) from 0.6.0 to 0.7.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil-ds-output-targets/releases"><code>@stencil/angular-output-target</code>'s releases</a>.</em></p> <blockquote> <h2><code>@stencil/angular-output-target</code><a href="https://github.com/0"><code>@0</code></a>.7.0</h2> <h2>What's Changed</h2> <ul> <li>feat(angular): omit output related imports for components with no event by <a href="https://github.com/KariiO"><code>@KariiO</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-ds-output-targets/pull/330">ionic-team/stencil-ds-output-targets#330</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/KariiO"><code>@KariiO</code></a> made their first contribution in <a href="https://redirect.github.com/ionic-team/stencil-ds-output-targets/pull/330">ionic-team/stencil-ds-output-targets#330</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/ionic-team/stencil-ds-output-targets/compare/v0.8.4...@stencil/angular-output-target@0.7.0">https://github.com/ionic-team/stencil-ds-output-targets/compare/v0.8.4...<code>@stencil/angular-output-target</code><code>@0.7.0</code></a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ionic-team/stencil-ds-output-targets/commit/a5af0cac649fe5156b56eaca7bd2855b900850fb"><code>a5af0ca</code></a> release(angular): v0.7.0</li> <li><a href="https://github.com/ionic-team/stencil-ds-output-targets/commit/f04737d3210ead5fe2d1b150c33f622c960abef7"><code>f04737d</code></a> fix(vue): Fix typechecking in library code for the Vue output target. (<a href="https://redirect.github.com/ionic-team/stencil-ds-output-targets/issues/342">#342</a>)</li> <li><a href="https://github.com/ionic-team/stencil-ds-output-targets/commit/43447972cc1de009acb5346743168853422ff5d2"><code>4344797</code></a> feat(angular): omit output related imports for components with no event (<a href="https://redirect.github.com/ionic-team/stencil-ds-output-targets/issues/330">#330</a>)</li> <li><a href="https://github.com/ionic-team/stencil-ds-output-targets/commit/6a9d4fc8c3c5a9c6b4bf0f0e569503b0b3f0acdd"><code>6a9d4fc</code></a> chore(repo): use stale configuration for ionitron (<a href="https://redirect.github.com/ionic-team/stencil-ds-output-targets/issues/341">#341</a>)</li> <li><a href="https://github.com/ionic-team/stencil-ds-output-targets/commit/b2a78e9b90431540a2af0c94058738a7a9c8c9c2"><code>b2a78e9</code></a> release(vue): v0.8.4</li> <li><a href="https://github.com/ionic-team/stencil-ds-output-targets/commit/97b1d3cf48c51a8334fd1f8b42d655e52247e483"><code>97b1d3c</code></a> chore(release): swapping lerna to use independent mode for versioning. (<a href="https://redirect.github.com/ionic-team/stencil-ds-output-targets/issues/337">#337</a>)</li> <li><a href="https://github.com/ionic-team/stencil-ds-output-targets/commit/284cbbec23133b7ee1bdd22ad8af9e4992cd1203"><code>284cbbe</code></a> chore(release): was accidentally running an action as a workflow. (<a href="https://redirect.github.com/ionic-team/stencil-ds-output-targets/issues/335">#335</a>)</li> <li><a href="https://github.com/ionic-team/stencil-ds-output-targets/commit/594920bbc61ee35c2a88979b0a20538f285066c9"><code>594920b</code></a> chore(ci): bumping which github action version we use for node. (<a href="https://redirect.github.com/ionic-team/stencil-ds-output-targets/issues/333">#333</a>)</li> <li><a href="https://github.com/ionic-team/stencil-ds-output-targets/commit/35693763bba42a6b288672d38ead999cc721567a"><code>3569376</code></a> chore(release): Adding the ability to cut a manual release from GH Actions (#...</li> <li><a href="https://github.com/ionic-team/stencil-ds-output-targets/commit/e693e4c9cc6c233bbdefcf7554efb81b8e566ae7"><code>e693e4c</code></a> chore(dev): Adding Volta to the package.json (<a href="https://redirect.github.com/ionic-team/stencil-ds-output-targets/issues/328">#328</a>)</li> <li>Additional commits viewable in <a href="https://github.com/ionic-team/stencil-ds-output-targets/compare/v0.6.0...@stencil/angular-output-target@0.7.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Issue number: N/A --------- This change ensures that Ionicons always stays up to date in Ionic Framework with Dependabot.
Release 7.0.8
Issue number: resolves #27470 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Passing multiple elements in to an inline modal causes `.ion-page` to not get set. This causes content to get pushed off the bottom of the modal equal to the height of the header. React has some special CSS that prevents this: https://github.com/ionic-team/ionic-framework/blob/eb2772c0ce623de70cce42b5d36e86cdbba7bafb/packages/react/src/components/createInlineOverlayComponent.tsx#L137-L140 However, I think this should be delegated to `.ion-page` instead so the behavior is consistent across frameworks. For example, Angular uses `.ion-page`: https://github.com/ionic-team/ionic-framework/blob/eb2772c0ce623de70cce42b5d36e86cdbba7bafb/angular/src/directives/overlays/modal.ts#L82 ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Inline overlays in Ionic React and Ionic Vue wrap child content in `.ion-delegate-host.ion-page`. - Removed the custom flex styles from Ionic React as `.ion-page` has its own styles. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Revised Design Doc: https://github.com/ionic-team/ionic-framework-design-documents/pull/84
Issue number: resolves #27338 --------- ## What is the current behavior? Segment button on `md` mode shows two ripple effects: once on pointerdown and again on pointerup ## What is the new behavior? Segment button on `md` mode only shows a ripple effect on pointerdown ## Does this introduce a breaking change? - [ ] Yes - [x] No --------- Co-authored-by: Brandy Carney <brandy@ionic.io>
Issue number: Resolves #27503 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Ionic Framework wraps the implementation around Capacitor's Keyboard plugin API, to provide additional functionality and behavior "automatically" in Ionic, when the plugin is installed. Certain methods such as `getResizeMode()` are only available for certain platforms and will cause an error when running in the unsupported platform. Ionic Framework does not check to see if that platform is active before calling potentially unsupported methods, which leads to an exception for scenarios such as this - calling `getResizeMode()` on Android. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Handles the uncaught exception by returning `undefined` if the plugin method is unavailable. - Developers do not receive an uncaught exception on Android when using the Capacitor Keyboard plugin with Ionic Framework ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Dev-build: `7.0.8-dev.11684444351.1b1ab142` (outdated)
Release 7.0.9
Issue number: N/A
---------
<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->
<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->
## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->
The Angular implementation of `ion-tabs` uses SASS styles in the inline
usage for styles:
```ts
styles: [`
:host {
z-index: $z-index-page-container;
}
`]
```
However Angular is expecting CSS mark-up by default. This results in an
invalid value being assigned to the `z-index`.
## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->
- Removes the invalid style from the tabs stylesheet
- Removes unnecessary leading whitespace from the template
## Does this introduce a breaking change?
- [ ] Yes
- [x] No
<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->
## Other information
<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->
Issue number: resolves #27566 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> The `touchstart` listener for focus visible is not marked as passive. This causes a browser delay in case `touchstart` calls `ev.preventDefault()`. However, we are not doing that in this block of code. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Added `passive: true` to the `touchstart` listener to avoid the browser delay. Note that this is only needed for touch and wheel events which is why I only modified `touchstart`: https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
…#27533) Bumps [@playwright/test](https://github.com/Microsoft/playwright) from 1.33.0 to 1.34.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/Microsoft/playwright/releases"><code>@playwright/test</code>'s releases</a>.</em></p> <blockquote> <h2>v1.34.0</h2> <h3>Highlights</h3> <ul> <li> <p>UI Mode now shows steps, fixtures and attachments: <!-- raw HTML omitted --></p> </li> <li> <p>New property <a href="https://playwright.dev/docs/api/class-testproject#test-project-teardown"><code>testProject.teardown</code></a> to specify a project that needs to run after this and all dependent projects have finished. Teardown is useful to cleanup any resources acquired by this project.</p> <p>A common pattern would be a <code>setup</code> dependency with a corresponding <code>teardown</code>:</p> <pre lang="js"><code>// playwright.config.ts import { defineConfig } from '@playwright/test'; <p>export default defineConfig({ projects: [ { name: 'setup', testMatch: /global.setup.ts/, teardown: 'teardown', }, { name: 'teardown', testMatch: /global.teardown.ts/, }, { name: 'chromium', use: devices['Desktop Chrome'], dependencies: ['setup'], }, { name: 'firefox', use: devices['Desktop Firefox'], dependencies: ['setup'], }, { name: 'webkit', use: devices['Desktop Safari'], dependencies: ['setup'], }, ], }); </code></pre></p> </li> <li> <p>New method <a href="https://playwright.dev/docs/test-assertions#expectconfigure"><code>expect.configure</code></a> to create pre-configured expect instance with its own defaults such as <code>timeout</code> and <code>soft</code>.</p> <pre lang="js"><code>const slowExpect = expect.configure({ timeout: 10000 }); await slowExpect(locator).toHaveText('Submit'); <p>// Always do soft assertions. const softExpect = expect.configure({ soft: true }); </code></pre></p> </li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/playwright/commit/4aee014caf4d5f14700a18dfc25014812e1f4414"><code>4aee014</code></a> chore: mark 1.34.0 (<a href="https://redirect.github.com/Microsoft/playwright/issues/23123">#23123</a>)</li> <li><a href="https://github.com/microsoft/playwright/commit/bf25a936175765c89bf9e0e241c0816995e6e025"><code>bf25a93</code></a> cherry-pick(<a href="https://redirect.github.com/Microsoft/playwright/issues/23171">#23171</a>): fix(tracing): when zipping remotely, use correct file na...</li> <li><a href="https://github.com/microsoft/playwright/commit/7effaf4f22fc658833e608415634185a43f7e535"><code>7effaf4</code></a> cherry-pick(<a href="https://redirect.github.com/Microsoft/playwright/issues/23166">#23166</a>): chore: fix file view padding</li> <li><a href="https://github.com/microsoft/playwright/commit/ef18287266b0a9131c70dd552964884c6af682ec"><code>ef18287</code></a> cherry-pick(<a href="https://redirect.github.com/Microsoft/playwright/issues/23165">#23165</a>): docs: update release notes</li> <li><a href="https://github.com/microsoft/playwright/commit/552cba8c05b1750dea5fea84072dfdf7405545f1"><code>552cba8</code></a> cherry-pick(<a href="https://redirect.github.com/Microsoft/playwright/issues/23148">#23148</a>): chore: do not annotate actions after failed ones as time...</li> <li><a href="https://github.com/microsoft/playwright/commit/cd94a3f01dd9693a167a5f66a4096e7ca58bd879"><code>cd94a3f</code></a> cherry-pick(<a href="https://redirect.github.com/Microsoft/playwright/issues/23144">#23144</a>): feat(connect): <code>pw:server:channel</code> and <code>pw:socks</code> debug ...</li> <li><a href="https://github.com/microsoft/playwright/commit/3543a741fdf67cf14f2457c5058ef03691c3036e"><code>3543a74</code></a> cherry-pick(<a href="https://redirect.github.com/Microsoft/playwright/issues/23140">#23140</a>): docs: add dialog/consoleMessage helper methods for langu...</li> <li><a href="https://github.com/microsoft/playwright/commit/7196f82e52571d177f0956cb2913add007a52dbf"><code>7196f82</code></a> cherry-pick(<a href="https://redirect.github.com/Microsoft/playwright/issues/23143">#23143</a>): test: add attachment tests</li> <li><a href="https://github.com/microsoft/playwright/commit/32c247b81556e6af9b2023438dc4628caa249c8f"><code>32c247b</code></a> cherry-pick(<a href="https://redirect.github.com/Microsoft/playwright/issues/23139">#23139</a>): chore: opt out of trace attachments</li> <li><a href="https://github.com/microsoft/playwright/commit/c551cce74e47a124cf8ad7f79cda3ade7ac88a45"><code>c551cce</code></a> cherry-pick(<a href="https://redirect.github.com/Microsoft/playwright/issues/23130">#23130</a>): feat(chromium): roll to r1064 (<a href="https://redirect.github.com/Microsoft/playwright/issues/23132">#23132</a>)</li> <li>Additional commits viewable in <a href="https://github.com/Microsoft/playwright/compare/v1.33.0...v1.34.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com> Co-authored-by: ionitron <hi@ionicframework.com>
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> PRs are first assigned to the team before being assigned to a single team member. This causes reviews to show up https://github.com/notifications for everyone even if they are not the final reviewer. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - GitHub automatically assigns reviewers now, so I removed the global Framework team codeowner. All PRs in this repo should have a team member automatically assigned. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> The basic list test screenshots capture a portion of the box shadow from the `ion-header`. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Removes the `ion-header` from the test template for screenshot capture - Only visually captures the `ion-list` ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> --------- Co-authored-by: ionitron <hi@ionicframework.com>
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Sometimes the datetime picker hasn't scrolled to the correct date yet before the screenshot is taken. (See JIRA ticket for a failing build.) ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - The test waits until the picker has scrolled before taking the screenshot. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Hopefully this is all that's needed. I did a few runs and it hasn't failed, but it's hard to know with flaky tests 🙃
Release 7.0.10
Bumps [@stencil/core](https://github.com/ionic-team/stencil) from 3.2.2 to 3.3.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil/releases"><code>@stencil/core</code>'s releases</a>.</em></p> <blockquote> <h2>🍭 3.3.0 (2023-05-23)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>compiler:</strong> components typedef path aliases (<a href="https://redirect.github.com/ionic-team/stencil/issues/4365">#4365</a>) (<a href="https://github.com/ionic-team/stencil/commit/fd63c1779a2b4889be536e23ad763199f02d861d">fd63c17</a>)</li> </ul> <h3>Features</h3> <ul> <li><strong>node</strong> add support for node v20 (<a href="https://redirect.github.com/ionic-team/stencil/pull/4368">#4368</a>) (<a href="https://github.com/ionic-team/stencil/commit/ffe1847062ccae0e2b525ac290e3ac977e3ad6a3">ffe1847</a>)</li> <li><strong>testing:</strong> support puppeteer's 'headless': 'new' (<a href="https://redirect.github.com/ionic-team/stencil/issues/4356">#4356</a>) (<a href="https://github.com/ionic-team/stencil/commit/79dc0159d216824d623e34f814dfeb32474a1550">79dc015</a>)</li> <li><strong>typescript:</strong> upgrade to TypeScript 5 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4315">#4315</a>) (<a href="https://github.com/ionic-team/stencil/commit/0b6621f21634b7498de0666a872ffcacc93fef87">0b6621f</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil/blob/main/CHANGELOG.md"><code>@stencil/core</code>'s changelog</a>.</em></p> <blockquote> <h1>🍭 <a href="https://github.com/ionic-team/stencil/compare/v3.2.2...v3.3.0">3.3.0</a> (2023-05-23)</h1> <h3>Bug Fixes</h3> <ul> <li><strong>compiler:</strong> components typedef path aliases (<a href="https://redirect.github.com/ionic-team/stencil/issues/4365">#4365</a>) (<a href="https://github.com/ionic-team/stencil/commit/fd63c1779a2b4889be536e23ad763199f02d861d">fd63c17</a>)</li> </ul> <h3>Features</h3> <ul> <li><strong>node</strong> add support for node v20 (<a href="https://redirect.github.com/ionic-team/stencil/pull/4368">#4368</a>) (<a href="https://github.com/ionic-team/stencil/commit/ffe1847062ccae0e2b525ac290e3ac977e3ad6a3">ffe1847</a>)</li> <li><strong>testing:</strong> support puppeteer's 'headless': 'new' (<a href="https://redirect.github.com/ionic-team/stencil/issues/4356">#4356</a>) (<a href="https://github.com/ionic-team/stencil/commit/79dc0159d216824d623e34f814dfeb32474a1550">79dc015</a>)</li> <li><strong>typescript:</strong> upgrade to TypeScript 5 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4315">#4315</a>) (<a href="https://github.com/ionic-team/stencil/commit/0b6621f21634b7498de0666a872ffcacc93fef87">0b6621f</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ionic-team/stencil/commit/7515c4b83659faee0c856f7877bde8fb564391f5"><code>7515c4b</code></a> 🍭 v3.3.0</li> <li><a href="https://github.com/ionic-team/stencil/commit/b34a88dd7426b18c75ee68fdccf2a114be373c6d"><code>b34a88d</code></a> chore(karma): update package-lock format (<a href="https://redirect.github.com/ionic-team/stencil/issues/4417">#4417</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/15e4743e7ee4abe7c9feb19dffb9fab8d3b0c378"><code>15e4743</code></a> chore(readme): add discord to readme (<a href="https://redirect.github.com/ionic-team/stencil/issues/4408">#4408</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/9a0207588bf4a8f3fb426e656d3d59f34325b162"><code>9a02075</code></a> chore(deps): update dependency webpack to v5.83.1 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4413">#4413</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/db39b030379c384ba8a9b0c79e669de6c3e93fca"><code>db39b03</code></a> chore(deps): update dependency npm to v9.6.7 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4410">#4410</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/a422f93452d25d3d4f7fc60eb64f75dafa26ee64"><code>a422f93</code></a> chore(deps): update dependency eslint to v8.41.0 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4416">#4416</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/a690e48c97234e0c7b420f2120db015addc1ca64"><code>a690e48</code></a> chore(deps): update dependency eslint-plugin-jsdoc to v44.2.4 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4409">#4409</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/a0bd934b4cc5d6ac607372ae3d23002daa6c1367"><code>a0bd934</code></a> chore(deps): update typescript-eslint to v5.59.6 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4411">#4411</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/bb329c937774924087e94d353a7bc7d2b6701e86"><code>bb329c9</code></a> chore(deps): update dependency <code>@types/node</code> to v20.2.1 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4412">#4412</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/0673f72197596facc2904e598f3029b96b4f4dba"><code>0673f72</code></a> chore(snc): remove in-memory-fs.spec snc violations (<a href="https://redirect.github.com/ionic-team/stencil/issues/4401">#4401</a>)</li> <li>Additional commits viewable in <a href="https://github.com/ionic-team/stencil/compare/v3.2.2...v3.3.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
Issue number: resolves #27558 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> The keyboard lifecycle util was always listening on visual viewport events even when in native environments. The visual viewport API is not reliable due to how the Ionic webview customizes how it resizes. We should only be listening on the native keyboard events in native environments. ionic-team/capacitor#3730 https://github.com/ionic-team/capacitor-plugins/blob/2e883f39329626062bcf876fe7d424432617229d/keyboard/ios/Plugin/Keyboard.m#L90-L98 ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Keyboard lifecycle util listens on native keyboard events only when in native environment ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
Issue number: resolves #27268 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> When tabbing on a radio group (modern syntax), it focuses on the next radio option inside the radio group. It replicates the behavior of the up/down keys. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - When tabbing on a radio group (modern syntax), it focuses on the next radio option of the next radio group. A spike ticket has been created to further investigate web accessibility and browser compatibility. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> N/A
|
|
github-actions
bot
added
package: angular
pointerCoord usage was removed on main.
The `win` utility was moved to the browser/ folder.
sean-perkins
requested review from
a team,
averyjohnston and
liamdebeasi
as code owners
averyjohnston
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?
Other information