Skip to content

Conversation

@sean-perkins
Copy link
Contributor

Issue number: N/A


What is the current behavior?

The sync script for the React package is out of date. It will unintentionally delete the symlink directory of the build output from core/, which breaks the build for the package during local development.

What is the new behavior?

  • Updates the sync script to package and install the core package
  • Matches the implementation pattern used for the sync script in our other packages

Does this introduce a breaking change?

  • Yes
  • No

Other information

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the package: react @ionic/react package label Aug 17, 2023
@sean-perkins sean-perkins marked this pull request as ready for review August 17, 2023 20:27
@sean-perkins sean-perkins added this pull request to the merge queue Aug 18, 2023
Merged via the queue into main with commit 1015c06 Aug 18, 2023
@sean-perkins sean-perkins deleted the sp/react-sync-script branch August 18, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: react @ionic/react package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants