fix(menu): remove app dir from safe area padding #28123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
averyjohnston
left a comment
averyjohnston
left a comment
There was a problem hiding this comment.
This looks good, just had a quick comment on... well, the comments. 😆
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
The
--ion-safe-area-leftand--ion-safe-area-rightvariables inion-menuare being set as if they use the app's direction. It's been determined that safe area is not logical and uses the device's direction. The current implementation is adding padding in the wrong sides forion-toolbarandion-contentwithin aion-menu.Additionally,
ion-menudoes not use the entire screen so the safe area only needs to be applied to the side that is touching the device screen.What is the new behavior?
--ion-safe-area-leftand--ion-safe-area-rightvariables to the correct values based on the device's direction.ion-toolbaris adding--ion-safe-area-leftand--ion-safe-area-rightbased on the device's direction.ion-toolbarcan now inherit the correct values from--ion-safe-area-leftand--ion-safe-area-right.ion-contentcan now inherit the correct values from--ion-safe-area-leftand--ion-safe-area-right.Does this introduce a breaking change?
Other information
Dev build: 7.3.4-dev.11694015543.18bc484f