Skip to content

Conversation

@liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Sep 6, 2023

Issue number: N/A


What is the current behavior?

When the "Update Reference Screenshot" job is run but no new screenshots are generated, the following error is logged:

nothing added to commit but untracked files present (use "git add" to track)
Error: Process completed with exit code 1.

This is happening because there are no files to commit when running git commit. Brandy noted that this was confusing since it doesn't actually tell you why there are no files to commit.

What is the new behavior?

  • If there are no diffs to commit then the update screenshot script will log a message saying that no screenshot diffs were generated.

Example:

⚠️ Error: No new screenshots generated ⚠️
This means that there were zero visual diffs when running screenshot tests.
Make sure you have pushed any code changes that would result in visual diffs.

https://github.com/ionic-team/ionic-framework/actions/runs/6099399582/job/16552017414

Does this introduce a breaking change?

  • Yes
  • No

Other information

@liamdebeasi liamdebeasi marked this pull request as ready for review September 6, 2023 16:06
@liamdebeasi liamdebeasi added this pull request to the merge queue Sep 6, 2023
Merged via the queue into main with commit 4b4ad75 Sep 6, 2023
@liamdebeasi liamdebeasi deleted the update-screenshot-error branch September 6, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants