chore(ci): account for new screenshots in error logging #28166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamdebeasi
requested review from
a team and
mapsandapps
and removed request for
a team
mapsandapps
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
We checked
git diffto see if new screenshots were generated. If no new screenshots were generated then we print a user-friendly message informing the dev what happened. However,git diffdoes not account for untracked changes (i.e. new screenshots).As a result, this prevented new screenshots from being committed.
What is the new behavior?
-Nflag which is short for--intent-to-add. This adds an entry with no content which causes the new screenshots to show up when runninggit diff. We later add the contents of the image.Example test run of this working: https://github.com/ionic-team/ionic-framework/actions/runs/6174263712/job/16759260534
Does this introduce a breaking change?
Other information