refactor(select): remove legacy property and styling #29019 #29025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
package: core
brandyscarney
commented
Feb 12, 2024
Comment on lines
-7
to
-18
| /// @prop - Padding top of the select | ||
| $select-ios-padding-top: $item-ios-padding-top !default; | ||
|
|
||
| /// @prop - Padding end of the select | ||
| $select-ios-padding-end: ($item-ios-padding-end * 0.5) !default; | ||
|
|
||
| /// @prop - Padding bottom of the select | ||
| $select-ios-padding-bottom: $item-ios-padding-bottom !default; | ||
|
|
||
| /// @prop - Padding start of the select | ||
| $select-ios-padding-start: $item-ios-padding-start !default; | ||
|
|
There was a problem hiding this comment.
These variables were only used by the legacy select
brandyscarney
commented
Feb 12, 2024
Comment on lines
-7
to
-18
| /// @prop - Padding top of the select | ||
| $select-md-padding-top: $item-md-padding-top !default; | ||
|
|
||
| /// @prop - Padding end of the select | ||
| $select-md-padding-end: 0 !default; | ||
|
|
||
| /// @prop - Padding bottom of the select | ||
| $select-md-padding-bottom: $select-md-padding-top !default; | ||
|
|
||
| /// @prop - Padding start of the select | ||
| $select-md-padding-start: $item-md-padding-start !default; | ||
|
|
There was a problem hiding this comment.
These variables were only used by the legacy select
brandyscarney
commented
Feb 12, 2024
| ); | ||
| } | ||
|
|
||
| render() { |
There was a problem hiding this comment.
I didn't change the renderSelect() function but I moved it down in the file to where the render() function was which is why there is a larger diff
2 tasks
brandyscarney
requested review from
a team,
liamdebeasi,
sean-perkins and
thetaPC
as code owners
liamdebeasi
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes the changes to remove the legacy property for the select as part of #29024. That pull request specifically focuses on updating tests to remove any legacy select usage. The internal ticket suggested separating these changes into individual pull requests. Please refer to the mentioned pull request for a detailed description of the combined changes from both pull requests. This will be merged into that pull request upon approval.