feat(searchbar): autocapitalize, dir, lang, maxlength, and minlength are inherited to native input #29098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
package: core
liamdebeasi
commented
Feb 28, 2024
| @@ -3,13 +3,37 @@ import { newSpecPage } from '@stencil/core/testing'; | |||
| import { Searchbar } from '../searchbar'; | |||
|
|
|||
| describe('searchbar: rendering', () => { | |||
| it('should inherit attributes', async () => { | |||
| it('should inherit properties on load', async () => { | |||
There was a problem hiding this comment.
I did not test updating the properties because that would be testing Stencil behavior. I am, however, testing updating attributes to verify that I configured the attribute watchers correctly.
liamdebeasi
requested review from
brandyscarney,
thetaPC,
sean-perkins and
a team
as code owners
This comment was marked as outdated.
This comment was marked as outdated.
liamdebeasi
commented
Feb 28, 2024
Comment on lines
+92
to
+93
| * In the future, this property will default to "off" to align with | ||
| * Input and Textarea, and the "!" will not be needed. |
There was a problem hiding this comment.
I can make a tech debt ticket for this, but my plan was to make the change once this is merged since Ionic 8 is in beta now (and we can still make breaking changes).
averyjohnston
approved these changes
Mar 1, 2024
|
Follow up PR: #29107 Blocked until |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #27606
What is the current behavior?
Certain attributes are not be inherited to the inner searchbar. Developers need control over these attributes to provide important context to users for things like language and text direction. Additionally, being able to control things like autocapitalize, maxlength, and minlength can help improve the user experience by a) guiding what should be entered into an input and b) removing autocapitalize where it's not appropriate.
What is the new behavior?
inputelement. We also watch them so any changes to the attributes are also inherited to the nativeinput.Does this introduce a breaking change?
Other information
Note: We expanded the scope of this work to also include input and textarea, and this work will be handled separately. However, the original request was only for searchbar so that's why I associated this PR with the linked issue.
Dev build:
7.7.3-dev.11709159644.114cd8b1