fix(overlay): do not hide overlay if toast is presented #29140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamdebeasi
commented
Mar 12, 2024
core/src/utils/overlays.ts
Outdated
| const nextPresentedOverlay = overlays[i + 1] ?? newTopMostOverlay; | ||
|
|
||
| // If next overlay has aria-hidden then all remaining overlays will have it too. | ||
| if (nextPresentedOverlay.hasAttribute('aria-hidden')) { |
There was a problem hiding this comment.
This may cause issues if the developer decides to present a new overlay with aria-hidden. However, I don't know how realistic that scenario is because then screen readers would never be able to focus the new overlay even without this change.
liamdebeasi
requested review from
thetaPC,
sean-perkins and
averyjohnston
and removed request for
a team and
thetaPC
averyjohnston
suggested changes
Mar 12, 2024
Co-authored-by: Amanda Johnston <90629384+amandaejohnston@users.noreply.github.com>
Co-authored-by: Amanda Johnston <90629384+amandaejohnston@users.noreply.github.com>
Co-authored-by: Amanda Johnston <90629384+amandaejohnston@users.noreply.github.com>
Co-authored-by: Amanda Johnston <90629384+amandaejohnston@users.noreply.github.com>
averyjohnston
approved these changes
Mar 12, 2024
sean-perkins
approved these changes
Mar 12, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #29139
What is the current behavior?
When implementing #28997 we did not consider the case where a Toast could be presented. When presenting a Toast after presenting a Modal the linked change causes the Modal to be hidden from screen readers.
What is the new behavior?
Does this introduce a breaking change?
Other information
Dev build:
7.7.5-dev.11710260658.1fc29a6c