feat: add experimental transition focus manager #29400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
liamdebeasi
commented
Apr 29, 2024
| test('should focus heading', async ({ page }) => { | ||
| const goToPageOneButton = page.locator('page-root ion-button.page-one'); | ||
| const nav = page.locator('ion-nav'); | ||
| const ionNavDidChange = await (nav as any).spyOnEvent('ionNavDidChange'); |
There was a problem hiding this comment.
I need to figure out why spyOnEvent does not exist on the type interface for our custom Locator, but the method does indeed exist.
There was a problem hiding this comment.
You need to cast:
import type { E2ELocator } from '@utils/test/playwright';
...
const nav = page.locator('ion-nav') as E2ELocator;
thetaPC
reviewed
Apr 30, 2024
thetaPC
approved these changes
May 1, 2024
sean-perkins
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #23650
What is the current behavior?
In traditional native applications, navigation will inform screen readers that the view has changed. This allows screen readers to focus the correct view. In a single page app on the web, this same concept does not exist. As a result, transitioning from Page A to Page B results in screen reader focus remaining on Page A. This means that users who rely on screen readers are not informed of view changes.
Currently, developers are responsible for implementing this on their own.
What is the new behavior?
There is some risk here by managing focus for the application. As a result, this feature is considered experimental and disabled by default. The team should collect feedback based on usage and enable it by default when they feel this feature is stable enough.
Does this introduce a breaking change?
Other information
tsconfig.jsonchange, reviewers should restart the Stencil dev server when checking out these changes locally.Reviewers: Please test both of the test template files on physical iOS and Android device with VoiceOver and TalkBack enabled, respectively.
Docs Link: ionic-team/ionic-docs#3627