Fix for issue 2521 #2988
Closed
Fix for issue 2521 #2988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix resolves the issue with subheaders and subfooters not displaying the title correctly in the page.
Fix for issue 2521
|
Sorry but this fix may break other peoples apps. |
|
Can you please explain what change could break other apps? I cannot see how this breaks any of the functionality in the framework? |
|
The fallback of the removal of display: block is display: flex, this is still a block style element the only difference is the way the children are layed out, as long as the contents of the bar-subheader are played out according to the ion-headerbar docs. There should be no effects on the apps. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix resolves the issue with subheaders and subfooters not displaying the title correctly in the page.