fix(vue): update output target and fix incorrect types #30259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
package: core
brandyscarney
changed the title
brandyscarney
approved these changes
Mar 18, 2025
There was a problem hiding this comment.
I confirmed in my testing that the latest dev build resolves the type errors and the user also confirmed it fixes their issue. Thank you! 🎉
brandyscarney
added a commit
that referenced
this pull request
Mar 19, 2025
Issue number: resolves #30254 --------- The type for `routerLink` was incorrectly set as `symbol`. The new update of the Vue output target to sets it to `string | symbol` - [ ] Yes - [x] No Dev build: `8.5.1-dev.11742238707.15ce0fe2` --------- Co-authored-by: Brandy Smith <6577830+brandyscarney@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #30254
What is the current behavior?
The type for
routerLinkwas incorrectly set assymbol.What is the new behavior?
The new update of the Vue output target to sets it to
string | symbolDoes this introduce a breaking change?
Other information
Dev build:
8.5.1-dev.11742238707.15ce0fe2