Skip to content

fix(tab-button): improve badge position and button states; #30655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: next
Choose a base branch
from
Draft

fix(tab-button): improve badge position and button states; #30655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9292044
- define padding space for ionic tab-button;
JoaoFerreira-FrontEnd Aug 27, 2025
7692398
Merge branch 'next' into ROU-11804
JoaoFerreira-FrontEnd Aug 27, 2025
17e26d3
- lint.fix
JoaoFerreira-FrontEnd Aug 27, 2025
291beb3
- update badge position;
JoaoFerreira-FrontEnd Aug 28, 2025
a72f4f7
- add only-icon, badge-vertical-bottom usecase;
JoaoFerreira-FrontEnd Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 57 additions & 0 deletions core/src/components/badge/test/hint/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,63 @@
</div>
</ion-list>

<ion-list id="tab-button-icon-bottom">
<ion-list-header>
<ion-label> Inside Tab Button - Only Icon </ion-label>
</ion-list-header>

<div class="ion-display-flex ion-align-items-center ion-justify-content-around ion-margin">
<ion-tab-bar>
<ion-tab-button href="" tab="tab-one" layout="label-hide">
<ion-icon name="home"></ion-icon>
<ion-badge size="small" vertical="top" color="danger"></ion-badge>
</ion-tab-button>

<ion-tab-button tab="schedule" class="e2eTabTwoButton" layout="label-hide">
<ion-icon name="globe"></ion-icon>
<ion-badge size="small" vertical="top" color="primary">
<ion-icon name="star"></ion-icon>
</ion-badge>
</ion-tab-button>

<ion-tab-button tab="tab-three" layout="label-hide">
<ion-icon name="logo-facebook"></ion-icon>
<ion-badge size="small" vertical="top" color="warning">999</ion-badge>
</ion-tab-button>

<ion-tab-button tab="tab-four" class="e2eTabFourButton" layout="label-hide">
<ion-icon name="chatbox"></ion-icon>
<ion-badge vertical="top" color="success" size="small"></ion-badge>
</ion-tab-button>
</ion-tab-bar>
</div>
<div class="ion-display-flex ion-align-items-center ion-justify-content-around ion-margin">
<ion-tab-bar>
<ion-tab-button href="" tab="tab-one" layout="label-hide">
<ion-icon name="home"></ion-icon>
<ion-badge size="small" vertical="bottom" color="danger"></ion-badge>
</ion-tab-button>

<ion-tab-button tab="schedule" class="e2eTabTwoButton" layout="label-hide">
<ion-icon name="globe"></ion-icon>
<ion-badge size="small" vertical="bottom" color="primary">
<ion-icon name="star"></ion-icon>
</ion-badge>
</ion-tab-button>

<ion-tab-button tab="tab-three" layout="label-hide">
<ion-icon name="logo-facebook"></ion-icon>
<ion-badge size="small" vertical="bottom" color="warning">999</ion-badge>
</ion-tab-button>

<ion-tab-button tab="tab-four" class="e2eTabFourButton" layout="label-hide">
<ion-icon name="chatbox"></ion-icon>
<ion-badge vertical="bottom" color="success" size="small"></ion-badge>
</ion-tab-button>
</ion-tab-bar>
</div>
</ion-list>

<ion-list id="button-top">
<ion-list-header>
<ion-label> Inside Button - Top Placement </ion-label>
Expand Down
34 changes: 23 additions & 11 deletions core/src/components/tab-button/tab-button.ionic.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@
:host {
--focus-ring-color: #{globals.$ion-border-focus-default};
--focus-ring-width: #{globals.$ion-border-radius-025};
--padding-top: #{globals.$ion-space-100};
--padding-end: #{globals.$ion-space-400};
--padding-bottom: #{globals.$ion-space-100};
--padding-start: #{globals.$ion-space-400};

@include globals.typography(globals.$ion-body-action-xs);

Expand Down Expand Up @@ -48,6 +52,7 @@

.button-native {
min-width: globals.$ion-scale-1200;
min-height: globals.$ion-scale-1200;

overflow: visible;

Expand Down Expand Up @@ -102,22 +107,23 @@

:host ::slotted(ion-badge) {
@include globals.position(null, null, null, calc(50% + globals.$ion-scale-300));
@include globals.transform(translate(-50%, -50%));
}

:host ::slotted(ion-badge.badge-vertical-top) {
@include globals.position(-2px);
@include globals.position(globals.$ion-scale-150);
}

:host ::slotted(ion-badge.badge-vertical-top:empty) {
@include globals.position(calc(globals.$ion-scale-100 * -1));
@include globals.position(globals.$ion-scale-050, null, null, calc(50% + globals.$ion-scale-250));
}

:host ::slotted(ion-badge.badge-vertical-bottom) {
@include globals.position(calc(50% - globals.$ion-scale-200));
:host(.tab-layout-icon-top) ::slotted(ion-badge.badge-vertical-bottom) {
@include globals.position(calc(50% - (globals.$ion-scale-050)));
}

:host ::slotted(ion-badge.badge-vertical-bottom:empty) {
@include globals.position(calc(50% - globals.$ion-scale-100));
:host(.tab-layout-icon-top) ::slotted(ion-badge.badge-vertical-bottom:empty) {
@include globals.position(50%, null, null, calc(50% + globals.$ion-scale-250));
}

:host ::slotted(ion-badge[vertical]:not(:empty)) {
Expand All @@ -130,13 +136,19 @@
}

:host(.tab-layout-icon-bottom) ::slotted(ion-badge.badge-vertical-top) {
@include globals.position(calc(50% - globals.$ion-scale-100));
@include globals.position(calc(50% + globals.$ion-scale-100));
}

:host(.tab-layout-icon-bottom) ::slotted(ion-badge.badge-vertical-bottom) {
@include globals.position(calc(50% + globals.$ion-scale-100));
:host(.tab-layout-icon-bottom) ::slotted(ion-badge.badge-vertical-top:empty) {
@include globals.position(50%);
}

:host(.tab-layout-icon-bottom) ::slotted(ion-badge.badge-vertical-bottom),
:host(.tab-layout-label-hide) ::slotted(ion-badge.badge-vertical-bottom) {
@include globals.position(calc(100% - globals.$ion-scale-100));
}

:host(.tab-layout-icon-bottom) ::slotted(ion-badge.badge-vertical-bottom:empty) {
@include globals.position(calc(50% + 14px));
:host(.tab-layout-icon-bottom) ::slotted(ion-badge.badge-vertical-bottom:empty),
:host(.tab-layout-label-hide) ::slotted(ion-badge.badge-vertical-bottom:empty) {
@include globals.position(calc(100% - globals.$ion-scale-050), null, null, calc(50% + globals.$ion-scale-250));
}
Loading