don't throw exceptions if the view is destroyed before the view is resized #4364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptarjan
changed the title
`resize()` is a promise, and the `$destroy` event can fire before it finishes, nulling out `scrollView` which subsequently throws an exception because we are trying to call methods on `null`.
|
ping? I'm applying this locally for my team and it is working great. |
|
Yes I also did a pull request but no nobody reacts ... |
mlynch
added a commit
that referenced
this pull request
Dec 6, 2015
don't throw exceptions if the view is destroyed before the view is resized
|
w00t thanks! Apologies for the delay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resize()is a promise, and the$destroyevent can fire before it finishes, nulling outscrollViewwhich subsequently throws an exception because we are trying to call methods onnull.