Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update main section of bower.json with bundle #4653

Merged
merged 1 commit into from
Dec 6, 2015
Merged

update main section of bower.json with bundle #4653

merged 1 commit into from
Dec 6, 2015

Conversation

laidig
Copy link

@laidig laidig commented Nov 21, 2015

This is proposed for two reasons:

  1. pulling the JS file into compliance with the bower.json spec ("The entry-point files necessary to use your package. Only one file per filetype."). I am not sure about how to handle the fonts.
  2. making the build process simpler for use with bower-main or bower-installer, as they can read the main section and grab only what is required.

Thanks for a great framework!

This is proposed for two reasons:
1. pulling the JS portion of Ionic into compliance with the bower.json spec ("The entry-point files necessary to use your package. Only one file per filetype."). I am not sure about how to handle the fonts.
2. making build process simpler for use with bower-main-files or bower-installer, as they can read the main section and grab only what is required.
mlynch added a commit that referenced this pull request Dec 6, 2015
update main section of bower.json with bundle
@mlynch mlynch merged commit 118ba8a into ionic-team:master Dec 6, 2015
@mlynch
Copy link
Contributor

mlynch commented Dec 6, 2015

Thanks!

@mlynch
Copy link
Contributor

mlynch commented Dec 17, 2015

Reverted this as per: #4789 in c9bd3e8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants