-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark theme #5441
Merged
Merged
Dark theme #5441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixing code alignment
Darken background color to give more relevance to itens with dark color
This commit overrides the toggle handle background color for MD dark theme
Overriding color of item-divider for material design dark theme
Overriding background color of outer content for material design dark theme
Creating dark theme for Material Design cards
Changing text default color on toolbar for Material Design dark theme
Changing default primary and secondary color for dark theme
thanks! we'll start to really go over this and tweak it a bit further of the next few weeks. Thanks for your help! |
Hey! Hi @matheusrocha89, I've been looking forward to test this dark theme of yours... so, if you could help me, which would the correct way of using the styles. Thanks for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #4967
This PR does a little upgrade on dark theme. Still needs some improvements:
Chips component does not have a variable to override so need some upgrades, also the searchbar on toolbar need improvements, does not have variables to override, both components still almost invisible, the need to fixed.
But I think we have an initial dark theme, thanks to @adamdbradley .