Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme #5441

Merged
merged 18 commits into from
Feb 15, 2016
Merged

Dark theme #5441

merged 18 commits into from
Feb 15, 2016

Conversation

matheusrocha89
Copy link
Contributor

Related to issue #4967
This PR does a little upgrade on dark theme. Still needs some improvements:

Chips component does not have a variable to override so need some upgrades, also the searchbar on toolbar need improvements, does not have variables to override, both components still almost invisible, the need to fixed.

But I think we have an initial dark theme, thanks to @adamdbradley .

Also fixing code alignment
Darken background color to give more relevance to itens with dark color
This commit overrides the toggle handle background color for MD dark theme
Overriding color of item-divider for material design dark theme
Overriding background color of outer content for material design dark theme
Creating dark theme for Material Design cards
Changing text default color on toolbar for Material Design dark theme
Changing default primary and secondary color for dark theme
adamdbradley added a commit that referenced this pull request Feb 15, 2016
@adamdbradley adamdbradley merged commit 9888a9c into ionic-team:2.0 Feb 15, 2016
@adamdbradley
Copy link
Contributor

thanks! we'll start to really go over this and tweak it a bit further of the next few weeks. Thanks for your help!

@tonicX
Copy link

tonicX commented Feb 26, 2016

Hey! Hi @matheusrocha89, I've been looking forward to test this dark theme of yours... so, if you could help me, which would the correct way of using the styles. Thanks for your work!

@matheusrocha89 matheusrocha89 deleted the dark-theme branch December 22, 2017 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants