Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/navigation/nav-controller-base.ts
Original file line number Diff line number Diff line change
Expand Up @@ -686,7 +686,7 @@ export class NavControllerBase extends Ion implements NavController {
_viewsWillLifecycles(enteringView: ViewController, leavingView: ViewController) {
if (enteringView || leavingView) {
this._zone.run(() => {
// Here, the order is important. WillLeave must called before WillEnter.
// Here, the order is important. WillLeave must be called before WillEnter.
leavingView && this._willLeave(leavingView, !enteringView);
enteringView && this._willEnter(enteringView);
});
Expand Down
2 changes: 1 addition & 1 deletion src/navigation/view-controller.ts
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,7 @@ export class ViewController {

/**
* @private
* The view has is about to leave and no longer be the active view.
* The view is about to leave and no longer be the active view.
*/
_willLeave(willUnload: boolean) {
this.willLeave.emit(null);
Expand Down