Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in comments for NavControllerBase and ViewController #9953

Merged
merged 2 commits into from
Jan 11, 2017
Merged

Fix typos in comments for NavControllerBase and ViewController #9953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34a54e8
docs(nav): fix typo
jsayol Jan 11, 2017
b6fc5f5
docs(view): fix typo
jsayol Jan 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/navigation/nav-controller-base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -686,7 +686,7 @@ export class NavControllerBase extends Ion implements NavController {
_viewsWillLifecycles(enteringView: ViewController, leavingView: ViewController) {
if (enteringView || leavingView) {
this._zone.run(() => {
// Here, the order is important. WillLeave must called before WillEnter.
// Here, the order is important. WillLeave must be called before WillEnter.
leavingView && this._willLeave(leavingView, !enteringView);
enteringView && this._willEnter(enteringView);
});
Expand Down
2 changes: 1 addition & 1 deletion src/navigation/view-controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,7 @@ export class ViewController {

/**
* @private
* The view has is about to leave and no longer be the active view.
* The view is about to leave and no longer be the active view.
*/
_willLeave(willUnload: boolean) {
this.willLeave.emit(null);
Expand Down