Fixes bug in readAsText() and adds readAsDataURL() in File plugin #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-DEVELOPER.md: Corrects 'npm run tslint' instruction to 'npm run lint' -CameraPreview: Fixes syntax error in hide -Base64ToGallery: Adds desc of options obj props
…e.readAsDataUrl() - File.readAsText(): window.resolveLocalFileSystemURL() was incorrectly implemented
Callback arg of window.resolveLocalFileSystemURL was fileSystem, but it actually returns fileEntry
|
We have a new file plugin in the PR section. #283 |
- Repo prop and link in desc were not pointing to the same gh repo as the plugin - setFlashMode() is not currently available in the repo that gets pulled by the corodova plugin
|
@ihadeed Would it not be advisable to merge so that the current version works properly while the new plugin is being finished? |
|
Sure, you're right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.