fix(loading/toast): don't call to dismiss pages if the view is an overlay

brandyscarney · brandyscarney · commit 8b25798a19b8 · 2016-12-20T15:02:30.000-05:00
fixes #9589
diff --git a/src/components/nav/overlay-portal.ts b/src/components/nav/overlay-portal.ts
@@ -37,7 +37,9 @@ export class OverlayPortal extends NavControllerBase {
 
     // on every page change make sure the portal has
     // dismissed any views that should be auto dismissed on page change
-    app.viewDidLeave.subscribe(this.dismissPageChangeViews.bind(this));
+    app.viewDidLeave.subscribe((ev) => {
+      !ev.isOverlay && this.dismissPageChangeViews();
+    });
   }
 
   @Input('overlay-portal')

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,9 @@ export class OverlayPortal extends NavControllerBase {`
`37`	`37`
`38`	`38`	`// on every page change make sure the portal has`
`39`	`39`	`// dismissed any views that should be auto dismissed on page change`
`40`		`- app.viewDidLeave.subscribe(this.dismissPageChangeViews.bind(this));`
	`40`	`+ app.viewDidLeave.subscribe((ev) => {`
	`41`	`+ !ev.isOverlay && this.dismissPageChangeViews();`
	`42`	`+ });`
`41`	`43`	`}`
`42`	`44`
`43`	`45`	`@Input('overlay-portal')`