Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A modal presented from a modal does not trigger onWillDismiss when dismissed. #11702

Closed
JustinPierce opened this issue May 17, 2017 · 2 comments · Fixed by #12056
Closed

A modal presented from a modal does not trigger onWillDismiss when dismissed. #11702

JustinPierce opened this issue May 17, 2017 · 2 comments · Fixed by #12056

Comments

@JustinPierce
Copy link

Ionic version: (check one with "x")
[ ] 1.x
[ ] 2.x
[x] 3.x

I'm submitting a ... (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/

Current behavior:
If a modal is presented from another modal, dismissing the top-most modal will not trigger the onWillDismiss handler. The onDidDismiss handler is triggered as expected.

Expected behavior:
Both the onWillDismiss and onDidDismiss handlers should be triggered.

Steps to reproduce:
Demo Plunker: http://plnkr.co/edit/yjjl5XHd8ru69V8vPDqC?p=preview

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):

Your system information:

 ordova CLI: 6.5.0
Ionic Framework Version: 3.0.1
Ionic CLI Version: 2.2.3
Ionic App Lib Version: 2.2.1
Ionic App Scripts Version: 1.3.4
ios-deploy version: Not installed
ios-sim version: Not installed
OS: Windows 10
Node Version: v6.10.0
Xcode version: Not installed
@jgw96 jgw96 added the v2 label May 17, 2017
@jgw96
Copy link
Contributor

jgw96 commented May 17, 2017

Good find! We will take a look at this.

manucorporat added a commit to manucorporat/ionic that referenced this issue Jun 15, 2017
manucorporat added a commit to manucorporat/ionic that referenced this issue Jun 16, 2017
manucorporat added a commit that referenced this issue Oct 6, 2017
* fix(overlay): onWillDismiss is called as expected

fixes #11702

* Fix condition
@ionitron-bot
Copy link

ionitron-bot bot commented Sep 1, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants