Fix for issue 2521

[elksson]

Please see comments on this pull request
#2988

[adamdbradley]

Can you please put together a codepen showing what it fixes, and one what devices/browsers/platforms? Display block may very well be there for a reason for a certain platform/browser. So while it may fix your scenario, I need to test it on all scenarios.

[42shadow42]

I have created a code-pen showing what is broken. In the CSS section I have included commented CSS that simulates the fix as suggested. Please note disabling the removed styles in the debugger WILL NOT resolve the issue, but removing them from the CSS will.

http://codepen.io/42shadow42/pen/Jopozg

[adamdbradley]

Sorry but I'm not seeing the differences? On which device/browser/platform/version is the issue happening on? Can you provide a before and after screen shot?

[42shadow42]

I encounter the issue in Chrome/Firefox/IE.
Before:

After:

Notice the title that says "Where did i go?" is not present in the first image.

Also if it helps, according to change logs. The display: block; was added during commit 659e0e0, which appears to be a CSS refactor. The notes indicate the flex styling was removed for being unnecessary.

[danbucholtz]

Hi @elksson,

This seems to be working. Nice work. Thanks for contributing to Ionic!

Thanks,
Dan

[alextrs]

This change breaks "grid" system in header. Take a look at http://codepen.io/alextrs/pen/RamWZO. Switch to previous version and you will see the expected behaviour.

Thanks

[alanmilinovic]

@alextrs +1