fix(icon): remove default <title> #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
averyjohnston
approved these changes
Jan 17, 2023
This was referenced Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most Ionicons SVGs contain a
<title>element embedded in the SVG data. The contents of these titles are usually autogenerated (ex:<title>ionicons-v5-a</title>) and as a result are not helpful to users consuming a site that display ionicons.This behavior also prevents developers from being able to specify custom
titleattributes.resolves #1082, resolves #1049, resolves #838
This PR removes the
<title>tags from the SVG sources. As a result, developers will now be able to provide atitleon theion-icon:Hovering over the icon will display a tooltip that reads "Add a recipe".
This is not considered a breaking change as the existing behavior is not correct. However, we are going to ship this in a minor release to minimize any unforeseen disruptions with this change.