fix: DomParser usage in SSR #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamdebeasi
approved these changes
Feb 9, 2023
There was a problem hiding this comment.
Tested with dev build 6.1.3-dev.11675958242.15132c48 on the repo provided in #1179, and this fix seems to work.
I don't know if we need the Build.isBrowser flag here and in the Icon component:
ionicons/src/components/icon/icon.tsx
Line 138 in 53ce49e
getSvgContent is only called if Build.isBrowser is true in loadIcon, so adding the Build check in getSvgContent seems redundant.
The original problem was that we were running new DOMParser() regardless of environment.
liamdebeasi
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DomParserclass is not available in a server context (only available in the browser). The previous changes were causing issues in SSR when trying to load an icon.This PR removes the implementation of instantiating the
DomParser, regardless of the environment.Resolves: #1179