Skip to content

breaking: modernize project #1447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 39 commits into from
May 2, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
805e0fc
chore: update project dependencies
christian-bromann Apr 16, 2025
0ff8fe0
remove lerna
christian-bromann Apr 16, 2025
aba4436
update build
christian-bromann Apr 16, 2025
8a1e876
plugin fixes
christian-bromann Apr 16, 2025
3ea484b
Icons do not display when the svg is loaded from a file:// URL in Safari
christian-bromann Apr 16, 2025
ee3489b
Update path fill in warning-outline.svg exclamation mark
christian-bromann Apr 16, 2025
17a8bc1
set currentColor - fixes #1420
christian-bromann Apr 16, 2025
ef3bfcb
add bell tag to notifications icon - fixes #1090
christian-bromann Apr 21, 2025
75e3c1a
add sliders and filters tags to option icon - fixes #1060
christian-bromann Apr 21, 2025
94be060
add loveseat tag to bed icon - closes #503
christian-bromann Apr 21, 2025
caf06f0
add contacts tag to people-circle
christian-bromann Apr 21, 2025
8edc744
fix data.json
christian-bromann Apr 21, 2025
f46c0c0
update data.json
christian-bromann Apr 24, 2025
455417b
set up prettier
christian-bromann Apr 24, 2025
d0d3797
fix contributing link
christian-bromann Apr 24, 2025
47632e8
prettier after rebase
christian-bromann Apr 25, 2025
53e5076
add missing rimraf
christian-bromann Apr 25, 2025
e60090c
add more comments
christian-bromann Apr 25, 2025
415c6a4
run prettier as part of the build
christian-bromann Apr 25, 2025
c179c22
set module resolution to bundle
christian-bromann Apr 25, 2025
944793f
consolidate contributing guidelines and coc as part of the root direc…
christian-bromann Apr 25, 2025
44506d7
fix link
christian-bromann Apr 25, 2025
fa266d5
copy svg into www
christian-bromann Apr 25, 2025
a97e712
cut me some visual slack
christian-bromann Apr 25, 2025
5cb09b3
Update readme.md
christian-bromann Apr 29, 2025
0243207
Update package.json
christian-bromann Apr 29, 2025
ec0f718
Update CONTRIBUTING.md
christian-bromann Apr 29, 2025
1e50470
remove generating collections
christian-bromann Apr 29, 2025
a51b2f8
ensure all directories exist
christian-bromann Apr 29, 2025
7c3eb98
only define snapshot tolerance in config
christian-bromann Apr 29, 2025
f99664b
update dependencies
christian-bromann Apr 29, 2025
dd8620b
Update src/components/icon/request.ts
christian-bromann Apr 29, 2025
e03470e
Update src/components/icon/request.ts
christian-bromann Apr 29, 2025
a124cdb
Update src/components/icon/request.ts
christian-bromann Apr 29, 2025
9770247
Update src/components/icon/request.ts
christian-bromann Apr 29, 2025
13ab199
prettier
christian-bromann Apr 29, 2025
7a2f833
update release pipeline
christian-bromann May 2, 2025
f34aa42
fix exports
christian-bromann May 2, 2025
65ad10f
recommend to use esm.sh as cdn
christian-bromann May 2, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 0 additions & 80 deletions .github/CONTRIBUTING.md

This file was deleted.

4 changes: 2 additions & 2 deletions .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: 🐛 Bug Report
description: Report a bug in the ion-icon component. Incorrect icons should use the "Incorrect Icon" template instead.
labels: ["triage"]
title: "bug: "
labels: ['triage']
title: 'bug: '
body:
- type: textarea
attributes:
Expand Down
6 changes: 3 additions & 3 deletions .github/ISSUE_TEMPLATE/feature_request.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: 💡 Feature Request
description: Suggest a new feature for the ion-icon component. Icon requests should use the "Icon Request" template instead.
labels: ["triage"]
title: "feat: "
labels: ['triage']
title: 'feat: '
body:
- type: textarea
attributes:
Expand All @@ -20,4 +20,4 @@ body:
- type: textarea
attributes:
label: Additional Information
description: Add any other context or screenshots about the feature request here.
description: Add any other context or screenshots about the feature request here.
6 changes: 3 additions & 3 deletions .github/ISSUE_TEMPLATE/icon_request.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: 🚀 Icon Request
description: Request a new icon
labels: ["triage"]
title: "icon request: "
labels: ['triage']
title: 'icon request: '
body:
- type: textarea
attributes:
Expand All @@ -16,4 +16,4 @@ body:
- type: textarea
attributes:
label: Additional Information
description: Add any other context about the icon request here.
description: Add any other context about the icon request here.
6 changes: 3 additions & 3 deletions .github/ISSUE_TEMPLATE/incorrect_icon.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: 😒 Incorrect Icon
description: Report an incorrect icon
labels: ["triage"]
title: "incorrect icon: "
labels: ['triage']
title: 'incorrect icon: '
body:
- type: textarea
attributes:
Expand All @@ -14,4 +14,4 @@ body:
label: Expected Behavior
description: A clear description of what the icon should look like. Please include any relevant screenshots.
validations:
required: true
required: true
10 changes: 5 additions & 5 deletions .github/ionic-issue-bot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ closeAndLock:

comment:
labels:
- label: "help wanted"
- label: 'help wanted'
message: >
This issue has been labeled as `help wanted`. This label is added to issues
that we believe would be good for contributors.
Expand Down Expand Up @@ -54,13 +54,13 @@ comment:

If you have already provided a code snippet and are seeing this message, it is likely that the code snippet was
not enough for our team to reproduce the issue.
- label: "community feedback wanted"
- label: 'community feedback wanted'
message: >
This issue has been labeled as `community feedback wanted`. This label is added to issues that we would like to hear from the community on before moving forward with any final decision on the feature request.


If the requested feature is something you would find useful for your applications, please react to the original post with 👍 (`+1`). If you would like to provide an additional use case for the feature, please post a comment.


The team will review this feedback and make a final decision. Any decision will be posted on this thread, but please note that we may ultimately decide not to pursue this feature.

Expand All @@ -71,7 +71,7 @@ comment:
noReply:
days: 14
maxIssuesPerRun: 100
label: "needs: reply"
label: 'needs: reply'
responseLabel: triage
exemptProjects: true
exemptMilestones: true
Expand All @@ -89,7 +89,7 @@ noReply:
noReproduction:
days: 14
maxIssuesPerRun: 100
label: "ionitron: needs reproduction"
label: 'ionitron: needs reproduction'
responseLabel: triage
exemptProjects: true
exemptMilestones: true
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/actions/build-core/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,4 @@ runs:
with:
name: ionicons-src
output: IoniconsSrc.zip
paths: src
paths: src
2 changes: 1 addition & 1 deletion .github/workflows/actions/download-archive/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ runs:
path: ${{ inputs.path }}
- name: Exract Archive
run: unzip -q -o ${{ inputs.path }}/${{ inputs.filename }}
shell: bash
shell: bash
2 changes: 1 addition & 1 deletion .github/workflows/actions/publish-npm/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ runs:
steps:
- uses: actions/setup-node@v4
with:
node-version: 18.x
node-version: 22.x
- name: Install latest npm
run: npm install -g npm@latest
shell: bash
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/actions/test-e2e/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -81,4 +81,4 @@ runs:
with:
name: test-results-${{ inputs.shard }}-${{ inputs.totalShards }}
output: TestResults-${{ inputs.shard }}-${{ inputs.totalShards }}.zip
paths: playwright-report
paths: playwright-report
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,4 @@ runs:
git add src/\*.png --force
git commit -m "chore(): add updated snapshots"
git push
shell: bash
shell: bash
2 changes: 1 addition & 1 deletion .github/workflows/actions/upload-archive/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ runs:
- uses: actions/upload-artifact@v4
with:
name: ${{ inputs.name }}
path: ${{ inputs.output }}
path: ${{ inputs.output }}
8 changes: 4 additions & 4 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: 'Ionicons Build'

on:
pull_request:
branches: [ '**' ]
branches: ['**']

# When pushing a new commit we should
# cancel the previous test run to not
Expand All @@ -27,7 +27,7 @@ jobs:
steps:
- uses: actions/checkout@v4
- uses: ./.github/workflows/actions/test-spec

test-e2e:
strategy:
# This ensures that all screenshot shard
Expand All @@ -51,7 +51,7 @@ jobs:
with:
shard: ${{ matrix.shard }}
totalShards: ${{ matrix.totalShards }}

# Screenshots are required to pass
# in order for the branch to be merge
# eligible. However, the screenshot tests
Expand All @@ -68,4 +68,4 @@ jobs:
steps:
- name: Check build matrix status
if: ${{ needs.test-e2e.result != 'success' }}
run: exit 1
run: exit 1
14 changes: 7 additions & 7 deletions .github/workflows/release-ionicons.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ jobs:
permissions:
id-token: write
steps:
- uses: actions/checkout@v4
- uses: ./.github/workflows/actions/publish-npm
with:
tag: ${{ inputs.tag }}
version: ${{ inputs.version }}
working-directory: './'
token: ${{ secrets.NPM_TOKEN }}
- uses: actions/checkout@v4
- uses: ./.github/workflows/actions/publish-npm
with:
tag: ${{ inputs.tag }}
version: ${{ inputs.version }}
working-directory: './'
token: ${{ secrets.NPM_TOKEN }}
52 changes: 26 additions & 26 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,36 +26,36 @@ jobs:
version: ${{ inputs.version }}
secrets:
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

finalize-release:
needs: [release-ionicons]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
token: ${{ secrets.IONITRON_TOKEN }}
fetch-depth: 0
- name: Configure Identity
# Commits from github-actions do not
# trigger other GitHub Actions. As a result,
# we publish releases from Ionitron instead
# so actions run when merging the release branch
# back into main.
run: |
git config user.name ionitron
git config user.email hi@ionicframework.com
shell: bash
# This ensures the local version of Lerna is installed
# and that we do not use the global Lerna version. We currently
# rely on functionality that does not exist in newer versions of Lerna.
- name: Install root dependencies
run: npm ci
shell: bash
- name: Create GitHub Release
run: npx lerna@5 version ${{ inputs.version }} --yes --force-publish='*' --conventional-commits --create-release github
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
shell: bash
- uses: actions/checkout@v4
with:
token: ${{ secrets.IONITRON_TOKEN }}
fetch-depth: 0
- name: Configure Identity
# Commits from github-actions do not
# trigger other GitHub Actions. As a result,
# we publish releases from Ionitron instead
# so actions run when merging the release branch
# back into main.
run: |
git config user.name ionitron
git config user.email hi@ionicframework.com
shell: bash
# This ensures the local version of Lerna is installed
# and that we do not use the global Lerna version. We currently
# rely on functionality that does not exist in newer versions of Lerna.
- name: Install root dependencies
run: npm ci
shell: bash
- name: Create GitHub Release
run: npx lerna@5 version ${{ inputs.version }} --yes --force-publish='*' --conventional-commits --create-release github
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
shell: bash

update-package-lock:
# This needs to run after finalize-release
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update-screenshots.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,4 +49,4 @@ jobs:
# to run when the screenshots are pushed.
with:
token: ${{ secrets.IONITRON_TOKEN }}
- uses: ./.github/workflows/actions/update-reference-screenshots
- uses: ./.github/workflows/actions/update-reference-screenshots
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,4 @@ www/
/playwright-report/
/playwright/.cache/
/src/**/*-snapshots
*.tgz
File renamed without changes.
Loading