fix(): adding aria-hidden no longer disables automatic rtl switching #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also: ionic-team/ionic-framework#23078
This PR fixes an issue where setting
aria-hidden="true"would causeflipRtlto always equalfalseunlessthis.flipRtlwas explicitly set.The reason this happened was
aria-hidden="true"caused the component to not automatically generate anaria-label. We used this label to determine whether or not we should automatically flip the icon according to RTL mode.To fix this, I created a private variable that holds the icon name. We reference this icon to determine the state of
flipRtl, and we also use this variable when auto generating anaria-label.