Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React wrapper treeshaking (dist custom elements) is broken in the Stencil latest release 2.9.0 #199

Closed
arvindanta opened this issue Oct 12, 2021 · 2 comments · Fixed by #208
Closed

React wrapper treeshaking (dist custom elements) is broken in the Stencil latest release 2.9.0 #199

arvindanta opened this issue Oct 12, 2021 · 2 comments · Fixed by #208
Labels
package: react @stencil/react-output-target package

Comments

@arvindanta
Copy link

arvindanta commented Oct 12, 2021 •
edited
Loading

Hi Team,

The React wrapper treeshaking ability is broken in the latest release of Stencil 2.9.0

Have added my observation in the below PR.

ionic-team/stencil#3039

ionic-team/stencil#3039 (comment)

#198 (comment)

Kindly help with it. Thanks
@splitinfinities splitinfinities added the package: react @stencil/react-output-target package label Nov 30, 2021
@liamdebeasi liamdebeasi mentioned this issue Dec 1, 2021
Merged
liamdebeasi added a commit that referenced this issue Dec 6, 2021
@liamdebeasi
fix(angular, react, vue): use defineCustomElement import to improve t…
bf2a2c8 
…reeshaking (#208)

resolves #199
@liamdebeasi
Copy link
Contributor

liamdebeasi commented Dec 6, 2021 •
edited
Loading

Hi there,

We identified an issue with the wrappers when using autoDefineCustomElements that caused treeshaking to not work properly. This was resolved via #208. This PR does not resolve any potential issues with proxyCustomElement as noted in #198 (comment).

@ionitron-bot
Copy link

ionitron-bot bot commented Mar 24, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of the output targets, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
package: react @stencil/react-output-target package
Projects
None yet
Milestone
No milestone
3 participants
@splitinfinities @liamdebeasi @arvindanta