-
Notifications
You must be signed in to change notification settings - Fork 792
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(es5): workaround around es5 helpers name conflict (#2013)
fixes #1916
- Loading branch information
1 parent
5669c28
commit b5353bd
Showing
1 changed file
with
7 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b5353bd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fix still not working, I can see loader.mjs has the the variables defined multiple times. (may be impacted by other libraries that we are using). And this leads to '#1842'
Can you please provide me any other workaround?
b5353bd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was testing it with 1.8.3
Tested with latest and it is working fine. (may be typescript fixed it in 3.8.3) :P