Skip to content

Commit

Permalink
chore(karma): re-enable firefox (#3210)
Browse files Browse the repository at this point in the history
Re-add Firefox to the list of target browsers for wider test coverage
across browsers. 

For now, we target Windows 10 only (like the other browsers). The
goal of this PR is to get programmatic testing under Firefox in place
  • Loading branch information
rwaskiewicz authored Jan 27, 2022
1 parent b00585f commit c24e792
Show file tree
Hide file tree
Showing 3 changed files with 44 additions and 6 deletions.
13 changes: 7 additions & 6 deletions test/karma/karma.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@ const browserStackLaunchers = {
os: 'Windows',
os_version: '10',
},
// bs_firefox: {
// base: 'BrowserStack',
// browser: 'firefox',
// os: 'Windows',
// os_version: '10',
// },
bs_firefox: {
base: 'BrowserStack',
browser: 'firefox',
os: 'Windows',
os_version: '10',
},
bs_edge: {
base: 'BrowserStack',
browser: 'edge',
Expand Down Expand Up @@ -70,6 +70,7 @@ module.exports = function (config) {
plugins: [
'karma-chrome-launcher',
'karma-browserstack-launcher',
'karma-firefox-launcher',
'karma-ie-launcher',
'karma-edge-launcher',
'karma-jasmine',
Expand Down
36 changes: 36 additions & 0 deletions test/karma/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions test/karma/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
"karma-browserstack-launcher": "^1.6.0",
"karma-chrome-launcher": "^3.1.0",
"karma-edge-launcher": "^0.4.2",
"karma-firefox-launcher": "^2.1.2",
"karma-ie-launcher": "^1.0.0",
"karma-jasmine": "^4.0.1",
"karma-polyfill": "^1.1.0",
Expand Down

0 comments on commit c24e792

Please sign in to comment.