Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add close event to Dialog #1348

Merged
merged 2 commits into from
May 18, 2019
Merged

Add close event to Dialog #1348

merged 2 commits into from
May 18, 2019

Conversation

arjunyel
Copy link
Contributor

I believe that I should be able to do an inline event listener for the close event. Example is the returning value from dialog section https://demo.agektmr.com/dialog/ https://html.spec.whatwg.org/multipage/interactive-elements.html#the-dialog-element

I believe that I should be able to do an inline event listener for the close event. Example is the returning value from dialog section https://demo.agektmr.com/dialog/ https://html.spec.whatwg.org/multipage/interactive-elements.html#the-dialog-element
@adamdbradley
Copy link
Contributor

We can't merge changed JSX yet until we update how h is imported. Once we get that updated we'll be able to merge this.

@manucorporat manucorporat merged commit f722975 into ionic-team:master May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants